From d58fb6a1c56db51255b07087a44669b17cf53dba Mon Sep 17 00:00:00 2001 From: Armagan Ersoz Date: Wed, 19 Mar 2025 12:09:59 +0800 Subject: [PATCH 1/2] Only highlight data-selected='true' --- packages/react/src/SubNav/SubNav.module.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/SubNav/SubNav.module.css b/packages/react/src/SubNav/SubNav.module.css index bb6a4c52c81..bac390dcd4b 100644 --- a/packages/react/src/SubNav/SubNav.module.css +++ b/packages/react/src/SubNav/SubNav.module.css @@ -60,7 +60,7 @@ transition: background-color 0.2s ease; } - &:is([data-selected]) { + &:is([data-selected='true']) { color: var(--fgColor-onEmphasis); background-color: var(--bgColor-accent-emphasis); /* stylelint-disable-next-line primer/colors */ From 0ac27cd34fcbc9ca4f650b06a9e181c77b49072e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Arma=C4=9Fan?= Date: Wed, 19 Mar 2025 12:15:03 +0800 Subject: [PATCH 2/2] Create strong-lemons-rescue.md --- .changeset/strong-lemons-rescue.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/strong-lemons-rescue.md diff --git a/.changeset/strong-lemons-rescue.md b/.changeset/strong-lemons-rescue.md new file mode 100644 index 00000000000..dd5464f408f --- /dev/null +++ b/.changeset/strong-lemons-rescue.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +SubNav: Update selected styles to only apply to `data-selected='true'`