From ecdc51e8c6c6dec0de2c0549c464ec5e62eb6b18 Mon Sep 17 00:00:00 2001 From: Josh Black Date: Tue, 11 Mar 2025 15:45:54 -0500 Subject: [PATCH 1/3] Update CheckboxOrRadioGroup.tsx --- .../CheckboxOrRadioGroup.tsx | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx b/packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx index dbe52aca196..ef6a63679c1 100644 --- a/packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx +++ b/packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx @@ -108,10 +108,10 @@ const CheckboxOrRadioGroup: React.FC {labelChild ? ( @@ -138,12 +138,12 @@ const CheckboxOrRadioGroup: React.FC {React.Children.toArray(rest).filter(child => React.isValidElement(child))} @@ -174,10 +174,10 @@ const CheckboxOrRadioGroup: React.FC {labelChild ? ( /* @@ -203,12 +203,12 @@ const CheckboxOrRadioGroup: React.FC {React.Children.toArray(rest).filter(child => React.isValidElement(child))} @@ -242,10 +242,10 @@ const CheckboxOrRadioGroup: React.FC @@ -272,12 +272,12 @@ const CheckboxOrRadioGroup: React.FC {React.Children.toArray(rest).filter(child => React.isValidElement(child))} From 35502f6990d8b2182ba8737a41d418b408b518be Mon Sep 17 00:00:00 2001 From: Josh Black Date: Tue, 11 Mar 2025 17:36:54 -0500 Subject: [PATCH 2/3] chore: format files --- .../CheckboxOrRadioGroup.tsx | 72 +++++++++++-------- 1 file changed, 42 insertions(+), 30 deletions(-) diff --git a/packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx b/packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx index ef6a63679c1..9072e0fa67b 100644 --- a/packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx +++ b/packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx @@ -108,10 +108,12 @@ const CheckboxOrRadioGroup: React.FC {labelChild ? ( @@ -138,12 +140,14 @@ const CheckboxOrRadioGroup: React.FC {React.Children.toArray(rest).filter(child => React.isValidElement(child))} @@ -174,10 +178,12 @@ const CheckboxOrRadioGroup: React.FC {labelChild ? ( /* @@ -203,12 +209,14 @@ const CheckboxOrRadioGroup: React.FC {React.Children.toArray(rest).filter(child => React.isValidElement(child))} @@ -242,10 +250,12 @@ const CheckboxOrRadioGroup: React.FC @@ -272,12 +282,14 @@ const CheckboxOrRadioGroup: React.FC {React.Children.toArray(rest).filter(child => React.isValidElement(child))} From 7a0475c4530424b4702aa00220d2adc56c26ec86 Mon Sep 17 00:00:00 2001 From: Josh Black Date: Thu, 13 Mar 2025 10:22:15 -0500 Subject: [PATCH 3/3] Create perfect-plants-trade.md --- .changeset/perfect-plants-trade.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/perfect-plants-trade.md diff --git a/.changeset/perfect-plants-trade.md b/.changeset/perfect-plants-trade.md new file mode 100644 index 00000000000..821cf28bba9 --- /dev/null +++ b/.changeset/perfect-plants-trade.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +Update base component for Checkbox and Radio to pass along correct prop type in React 19