Skip to content

fix(BaseStyles): set data-color-mode to auto when auto color mode #5649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 13, 2025
Merged

fix(BaseStyles): set data-color-mode to auto when auto color mode #5649

merged 4 commits into from
Mar 13, 2025

Conversation

@joshblack
Copy link
Member

@joshblack joshblack commented Feb 3, 2025

Update our BaseStyles component to set data-color-mode to auto when the colorMode is set to auto. This helps us out on the primer-docs side when we are doing SSR so that the fallbacks of custom properties resolve to the correct theme.

Changelog

New

Changed

  • Update our BaseStyles component to set data-color-mode to auto when the colorMode is set to auto

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

@joshblack joshblack requested a review from a team as a code owner February 3, 2025 19:00
@joshblack joshblack requested a review from jonrohan February 3, 2025 19:00
@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 05e9b29

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Feb 3, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 106.06 KB (-0.07% 🔽)
packages/react/dist/browser.umd.js 106.45 KB (+0.03% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5649 February 3, 2025 19:16 Inactive
@joshblack joshblack added this pull request to the merge queue Feb 4, 2025
@joshblack joshblack removed this pull request from the merge queue due to a manual request Feb 4, 2025
@primer-integration
Copy link

primer-integration bot commented Feb 4, 2025

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/360763

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Feb 4, 2025
@primer-integration
Copy link

primer-integration bot commented Feb 4, 2025

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5649 February 13, 2025 16:46 Inactive
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 13, 2025
@joshblack joshblack enabled auto-merge March 13, 2025 22:03
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@joshblack joshblack added this pull request to the merge queue Mar 13, 2025
Merged via the queue into main with commit 63ca6f2 Mar 13, 2025
44 checks passed
@joshblack joshblack deleted the fix/update-base-styles-color-mode-auto branch March 13, 2025 22:25
@primer primer bot mentioned this pull request Mar 13, 2025
Merged
hectahertz pushed a commit that referenced this pull request Mar 20, 2025
@joshblack @mperrotti @hectahertz
fix(BaseStyles): set data-color-mode to auto when auto color mode (#5649
3bcd592 
)

Co-authored-by: Mike Perrotti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan jonrohan approved these changes

@mperrotti mperrotti mperrotti approved these changes

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joshblack @jonrohan @mperrotti