Avoid TypeError in useAnnouncements
#5551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 67e55f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
camertron
changed the title
TypeError in useAnnouncements
github-actions
bot
added
the
integration-tests: recommended
Contributor
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
camertron
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
size-limit report 📦
|
github-actions
bot
added
integration-tests: failing
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/358253 |
|
🔴 golden-jobs completed with status |
camertron
added a commit
that referenced
this pull request
Jan 21, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
* Revert "Revert "Select panel loading states (#4929)" (#5136)" This reverts commit f93eb9b. * Use published primer/behaviors * Revert snapshot change to TextInput * Huh ok never mind * Use role in test * Prevent active descendant from resetting when items change * Allow loading state to be managed by the user * Encounter the loading state for the initial state announcement * It's working * Cleanup * Fix linting issues * Revert snapshots * test(vrt): update snapshots * Backport #5551 to this PR * Fix auto-focus behavior * Add test to ensure focus behavior * Allow consumers to pass an inputRef; DRY up timeout cleanup; simplify nullish coercion * DRY up announcement code; restore useAnnouncements hook for non-SelectPanel cases * Fix types tests * Remove testing ID * Remove confusing componentManagesLoading control in async story --------- Co-authored-by: Cameron Dutro <[email protected]> Co-authored-by: francinelucca <[email protected]> Co-authored-by: Marie Lucca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/4635
Changelog
New
Changed
TypeErrorin production. TheactiveItemvariable may benull.Removed
Rollout strategy
Testing & Reviewing
Merge checklist
- [ ] Added/updated tests- [ ] Added/updated documentation- [ ] Added/updated previews (Storybook)- [ ] Tested in Chrome- [ ] Tested in Firefox- [ ] Tested in Safari- [ ] Tested in Edge