Skip to content

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Dec 18, 2024

Changelog

New

Changed

Removed

Remove CSS modules feature flag from ButtonGroup

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: f43f12d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 18, 2024
@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 18, 2024
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.33 KB (-0.07% 🔽)
packages/react/dist/browser.umd.js 104.64 KB (-0.07% 🔽)

@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 18, 2024
@primer primer bot temporarily deployed to github-pages December 18, 2024 22:03 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5457 December 18, 2024 22:04 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/356022

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 19, 2024
@jonrohan jonrohan marked this pull request as ready for review December 19, 2024 22:49
@jonrohan jonrohan requested review from a team as code owners December 19, 2024 22:49
@jonrohan jonrohan added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit b1e5699 Jan 8, 2025
43 checks passed
@jonrohan jonrohan deleted the css_modules_remove_buttongroup branch January 8, 2025 23:40
@primer primer bot mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants