Skip to content

feat(SideNav): Convert SideNav to CSS modules behind feature flag #5413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 11, 2024
Merged

feat(SideNav): Convert SideNav to CSS modules behind feature flag #5413

merged 7 commits into from
Dec 11, 2024

Conversation

@JelloBagel
Copy link
Contributor

@JelloBagel JelloBagel commented Dec 11, 2024

Closes https://github.com/github/primer/issues/4132

Changelog

Changed

  • Convert SideNav to CSS modules behind primer_react_css_modules_team feature flag

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d17a5d8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 11, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5413 December 11, 2024 00:32 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.74 KB (+0.23% 🔺)
packages/react/dist/browser.umd.js 102.98 KB (0%)

@JelloBagel JelloBagel added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 11, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 11, 2024
@primer primer bot temporarily deployed to github-pages December 11, 2024 00:50 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5413 December 11, 2024 00:50 Inactive
@JelloBagel JelloBagel force-pushed the jellobagel-sidenav-cssmodules branch from 97e2bb7 to 193fea4 Compare December 11, 2024 15:58
@github-actions github-actions bot temporarily deployed to storybook-preview-5413 December 11, 2024 16:00 Inactive
@JelloBagel JelloBagel added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 11, 2024
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Dec 11, 2024
@primer primer bot temporarily deployed to github-pages December 11, 2024 16:35 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5413 December 11, 2024 16:36 Inactive
@JelloBagel JelloBagel force-pushed the jellobagel-sidenav-cssmodules branch from 0d726b7 to d17a5d8 Compare December 11, 2024 16:57
@primer-integration
Copy link

primer-integration bot commented Dec 11, 2024

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/354611

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 11, 2024
@primer-integration
Copy link

primer-integration bot commented Dec 11, 2024

🟢 golden-jobs completed with status success.

@JelloBagel JelloBagel marked this pull request as ready for review December 11, 2024 17:53
@JelloBagel JelloBagel requested a review from a team as a code owner December 11, 2024 17:53
@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Dec 11, 2024
@JelloBagel JelloBagel requested a review from joshblack December 11, 2024 17:53
Base automatically changed from jellobagel-sidenav-vrt to main December 11, 2024 18:49
@JelloBagel JelloBagel requested a review from a team as a code owner December 11, 2024 18:49
@JelloBagel JelloBagel added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 9f5a9ac Dec 11, 2024
40 checks passed
@JelloBagel JelloBagel deleted the jellobagel-sidenav-cssmodules branch December 11, 2024 19:05
@primer primer bot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@emilybrick emilybrick Awaiting requested review from emilybrick emilybrick is a code owner automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JelloBagel @joshblack