From 8e713a68a70747316d451afe9ec52fb80196c4e4 Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Fri, 6 Dec 2024 18:50:25 +0000 Subject: [PATCH 1/2] Move SelectPanel to staff --- .../react/src/experimental/SelectPanel2/SelectPanel.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react/src/experimental/SelectPanel2/SelectPanel.tsx b/packages/react/src/experimental/SelectPanel2/SelectPanel.tsx index b407db2cf19..a15bd539f33 100644 --- a/packages/react/src/experimental/SelectPanel2/SelectPanel.tsx +++ b/packages/react/src/experimental/SelectPanel2/SelectPanel.tsx @@ -30,7 +30,7 @@ import {useFeatureFlag} from '../../FeatureFlags' import classes from './SelectPanel.module.css' -const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_team' +const CSS_MODULES_FEATURE_FLAG = 'primer_react_css_modules_staff' const SelectPanelContext = React.createContext<{ title: string @@ -232,7 +232,7 @@ const Panel: React.FC = ({ [internalOpen, anchorRef.current, dialogRef.current], ) - /* + /* We want to cancel and close the panel when user clicks outside. See decision log: https://github.com/github/primer/discussions/2614#discussioncomment-8544561 */ @@ -468,7 +468,7 @@ const SelectPanelHeader: React.FC & {onBac data-description={description ? true : undefined} data-on-back={onBack ? true : undefined} > - {/* heading element is intentionally hardcoded to h1, it is not customisable + {/* heading element is intentionally hardcoded to h1, it is not customisable see https://github.com/github/primer/issues/2578 for context */} Date: Fri, 6 Dec 2024 11:05:03 -0800 Subject: [PATCH 2/2] Create fuzzy-owls-dance.md --- .changeset/fuzzy-owls-dance.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/fuzzy-owls-dance.md diff --git a/.changeset/fuzzy-owls-dance.md b/.changeset/fuzzy-owls-dance.md new file mode 100644 index 00000000000..e49adcb3de4 --- /dev/null +++ b/.changeset/fuzzy-owls-dance.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +Move Textarea component css module feature flag to staff