From a987a41392311368206051bfc9d64b9f20032909 Mon Sep 17 00:00:00 2001 From: Mike Perrotti Date: Mon, 25 Nov 2024 17:01:28 -0500 Subject: [PATCH 1/4] updates checkbox and radio label and legend styles --- .../react/src/FormControl/FormControl.tsx | 20 +++++++++---------- .../CheckboxOrRadioGroup.module.css | 3 ++- .../CheckboxOrRadioGroupLabel.tsx | 3 ++- .../src/internal/components/InputLabel.tsx | 1 - 4 files changed, 13 insertions(+), 14 deletions(-) diff --git a/packages/react/src/FormControl/FormControl.tsx b/packages/react/src/FormControl/FormControl.tsx index 6f65c70a2f1..a629806a353 100644 --- a/packages/react/src/FormControl/FormControl.tsx +++ b/packages/react/src/FormControl/FormControl.tsx @@ -172,17 +172,15 @@ const FormControl = React.forwardRef( {slots.leadingVisual} )} - {!slots.label?.props.visuallyHidden || slots.caption ? ( - *': {paddingLeft: 'var(--stack-gap-condensed)'}}}> - {slots.label} - {slots.caption} - - ) : ( - <> - {slots.label} - {slots.caption} - - )} + *': {paddingLeft: 'var(--stack-gap-condensed)'}, + '> label': {fontWeight: 'var(--base-text-weight-normal)'}, + }} + > + {slots.label} + {slots.caption} + ) : ( diff --git a/packages/react/src/internal/components/InputLabel.tsx b/packages/react/src/internal/components/InputLabel.tsx index b4d2fa43aed..ae56542e352 100644 --- a/packages/react/src/internal/components/InputLabel.tsx +++ b/packages/react/src/internal/components/InputLabel.tsx @@ -54,7 +54,6 @@ const InputLabel: React.FC> = ({ display: 'block', color: disabled ? 'fg.muted' : 'fg.default', cursor: disabled ? 'not-allowed' : 'pointer', - alignSelf: 'flex-start', ...sx, }} {...props} From 760cb8544062be140167648a8213b573042dec58 Mon Sep 17 00:00:00 2001 From: Mike Perrotti Date: Mon, 25 Nov 2024 17:06:50 -0500 Subject: [PATCH 2/4] adds changeset --- .changeset/smart-parrots-beam.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/smart-parrots-beam.md diff --git a/.changeset/smart-parrots-beam.md b/.changeset/smart-parrots-beam.md new file mode 100644 index 00000000000..ab4d1312df4 --- /dev/null +++ b/.changeset/smart-parrots-beam.md @@ -0,0 +1,6 @@ +--- +"@primer/react": patch +--- + +- Makes {Checkbox|Radio}Group `` bold and default font size +- Makes Checkbox and Radio `