Skip to content

feat(Overlay): Convert Overlay to CSS modules behind team feature flag #5310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Dec 11, 2024
Merged

feat(Overlay): Convert Overlay to CSS modules behind team feature flag #5310

merged 27 commits into from
Dec 11, 2024

Conversation

@francinelucca
Copy link
Member

@francinelucca francinelucca commented Nov 18, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/4135

Changelog

New

  • Overlay module css

Changed

  • Refactor Overlay to use CSS modules when team feature flag is turned on
  • Update SelectPanel import to new Overlay base component name (StyledOverlay -> BaseOverlay)

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 0a54dfc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Nov 18, 2024
@francinelucca francinelucca added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed staff Author is a staff member labels Nov 18, 2024
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 18, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5310 November 18, 2024 21:14 Inactive
@francinelucca
fix(Overlay): types and format
e9f3e29
@francinelucca
Merge branch 'francinelucca/4135-update-overlay-to-css-modules' of gi…
65c01bf 
…thub.com:primer/react into francinelucca/4135-update-overlay-to-css-modules
@github-actions github-actions bot temporarily deployed to storybook-preview-5310 November 19, 2024 16:55 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.49 KB (+0.05% 🔺)
packages/react/dist/browser.umd.js 102.86 KB (+0.1% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5310 November 19, 2024 18:49 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5310 November 19, 2024 19:00 Inactive
@langermank langermank added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Nov 19, 2024
langermank
langermank reviewed Nov 19, 2024
View reviewed changes
@francinelucca francinelucca removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 19, 2024
@francinelucca francinelucca added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 19, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5310 November 27, 2024 22:05 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 27, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5310 December 5, 2024 17:42 Inactive
@primer-integration
Copy link

primer-integration bot commented Dec 10, 2024

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/354358

@primer-integration
Copy link

primer-integration bot commented Dec 10, 2024

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Dec 10, 2024
@francinelucca francinelucca marked this pull request as ready for review December 10, 2024 19:48
@francinelucca francinelucca requested a review from a team as a code owner December 10, 2024 19:48
@francinelucca francinelucca added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 13ce9a3 Dec 11, 2024
48 checks passed
@francinelucca francinelucca deleted the francinelucca/4135-update-overlay-to-css-modules branch December 11, 2024 22:03
@primer primer bot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblack joshblack joshblack approved these changes

@TylerJDev TylerJDev Awaiting requested review from TylerJDev

@langermank langermank Awaiting requested review from langermank

Assignees

No one assigned

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@francinelucca @joshblack @langermank