Skip to content

feat(CheckBoxOrRadioGroup): Convert CheckBoxOrRadioGroup to CSS modules behind feature flag #5275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 14, 2024
Merged

feat(CheckBoxOrRadioGroup): Convert CheckBoxOrRadioGroup to CSS modules behind feature flag #5275

merged 6 commits into from
Nov 14, 2024

Conversation

@jonrohan
Copy link
Member

@jonrohan jonrohan commented Nov 13, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/4305

Changelog

New

Changed

Convert CheckBoxOrRadioGroup to CSS modules behind feature flag

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 09c3b3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 13, 2024
@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 13, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5275 November 13, 2024 21:01 Inactive
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 13, 2024
@primer primer bot temporarily deployed to github-pages November 13, 2024 21:11 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5275 November 13, 2024 21:12 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5275 November 13, 2024 21:56 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 98.94 KB (+0.22% 🔺)
packages/react/dist/browser.umd.js 99.31 KB (+0.24% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5275 November 13, 2024 22:05 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 13, 2024
@jonrohan jonrohan marked this pull request as ready for review November 13, 2024 22:38
@jonrohan jonrohan requested review from a team as code owners November 13, 2024 22:38
@jonrohan jonrohan requested a review from langermank November 13, 2024 22:38
@primer-integration
Copy link

primer-integration bot commented Nov 14, 2024

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/351114

@primer-integration
Copy link

primer-integration bot commented Nov 14, 2024

🔴 golden-jobs completed with status failure.

@jonrohan jonrohan marked this pull request as draft November 14, 2024 20:10
@jonrohan jonrohan changed the title chore(CheckBoxOrRadioGroup): Convert CheckBoxOrRadioGroup to CSS modules behind feature flag feat(CheckBoxOrRadioGroup): Convert CheckBoxOrRadioGroup to CSS modules behind feature flag Nov 14, 2024
@jonrohan jonrohan marked this pull request as ready for review November 14, 2024 21:40
@jonrohan jonrohan added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit d1b7bce Nov 14, 2024
44 checks passed
@jonrohan jonrohan deleted the css_modules_checkbox_or_radio_group branch November 14, 2024 23:28
@primer primer bot mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hussam-i-am hussam-i-am hussam-i-am approved these changes

@langermank langermank Awaiting requested review from langermank langermank is a code owner automatically assigned from primer/design-reviewers

@randall-krauskopf randall-krauskopf Awaiting requested review from randall-krauskopf

Assignees

No one assigned

Labels

integration-tests: failing Changes in this PR cause breaking changes in gh/gh staff Author is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonrohan @hussam-i-am