From 10b353d671affaf1af5297bc90f326893d85ce93 Mon Sep 17 00:00:00 2001 From: Marie Lucca Date: Wed, 9 Oct 2024 17:26:55 -0400 Subject: [PATCH 1/4] fix(ProgressBar): add aria-valuetext attribute --- packages/react/src/ProgressBar/ProgressBar.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react/src/ProgressBar/ProgressBar.tsx b/packages/react/src/ProgressBar/ProgressBar.tsx index 6c760bbd77d..9678af725f2 100644 --- a/packages/react/src/ProgressBar/ProgressBar.tsx +++ b/packages/react/src/ProgressBar/ProgressBar.tsx @@ -85,6 +85,7 @@ export const ProgressBar = forwardRef( 'aria-valuenow': progressAsNumber ? Math.round(progressAsNumber) : undefined, 'aria-valuemin': 0, 'aria-valuemax': 100, + 'aria-valuetext': progressAsNumber ? `${Math.round(progressAsNumber)}%` : undefined, } return ( From 984db3c1a35339a3a14a320560807dd97c70b017 Mon Sep 17 00:00:00 2001 From: Marie Lucca <40550942+francinelucca@users.noreply.github.com> Date: Wed, 9 Oct 2024 17:33:18 -0400 Subject: [PATCH 2/4] Create slimy-sloths-whisper.md --- .changeset/slimy-sloths-whisper.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/slimy-sloths-whisper.md diff --git a/.changeset/slimy-sloths-whisper.md b/.changeset/slimy-sloths-whisper.md new file mode 100644 index 00000000000..f2d11a45556 --- /dev/null +++ b/.changeset/slimy-sloths-whisper.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +fix(ProgressBar): add aria-valuetext attribute From 2af81d35ed36181054d4a28eca133528ae65fa19 Mon Sep 17 00:00:00 2001 From: Marie Lucca Date: Thu, 10 Oct 2024 14:56:11 -0400 Subject: [PATCH 3/4] test(ProgressBar): update snapshot --- .../react/src/__tests__/__snapshots__/ProgressBar.test.tsx.snap | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/react/src/__tests__/__snapshots__/ProgressBar.test.tsx.snap b/packages/react/src/__tests__/__snapshots__/ProgressBar.test.tsx.snap index e8f28759a8b..cd0422b606b 100644 --- a/packages/react/src/__tests__/__snapshots__/ProgressBar.test.tsx.snap +++ b/packages/react/src/__tests__/__snapshots__/ProgressBar.test.tsx.snap @@ -38,6 +38,7 @@ exports[`ProgressBar respects the "progress" prop 1`] = ` aria-valuemax={100} aria-valuemin={0} aria-valuenow={80} + aria-valuetext="80%" className="c0" role="progressbar" > From 23a7d0af92873bea460ba9612151b13d9083cb73 Mon Sep 17 00:00:00 2001 From: Marie Lucca <40550942+francinelucca@users.noreply.github.com> Date: Wed, 16 Oct 2024 13:32:36 -0400 Subject: [PATCH 4/4] Update changeset to minor --- .changeset/slimy-sloths-whisper.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/slimy-sloths-whisper.md b/.changeset/slimy-sloths-whisper.md index f2d11a45556..575b256e7b3 100644 --- a/.changeset/slimy-sloths-whisper.md +++ b/.changeset/slimy-sloths-whisper.md @@ -1,5 +1,5 @@ --- -"@primer/react": patch +"@primer/react": minor --- fix(ProgressBar): add aria-valuetext attribute