From 19224ed2acad3f1ebd05dd94d29984059480c452 Mon Sep 17 00:00:00 2001 From: Armagan Ersoz Date: Fri, 4 Oct 2024 10:22:03 +1000 Subject: [PATCH 1/5] Do not export all types publicly in the experimental bundle --- packages/react/src/TooltipV2/Tooltip.tsx | 4 ++-- .../react/src/__tests__/__snapshots__/exports.test.ts.snap | 2 -- packages/react/src/experimental/index.ts | 3 ++- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/packages/react/src/TooltipV2/Tooltip.tsx b/packages/react/src/TooltipV2/Tooltip.tsx index ab5c5fe6648..6a291be878a 100644 --- a/packages/react/src/TooltipV2/Tooltip.tsx +++ b/packages/react/src/TooltipV2/Tooltip.tsx @@ -123,7 +123,7 @@ const StyledTooltip = styled.span` ${sx}; ` -export type TooltipDirection = 'nw' | 'n' | 'ne' | 'e' | 'se' | 's' | 'sw' | 'w' +type TooltipDirection = 'nw' | 'n' | 'ne' | 'e' | 'se' | 's' | 'sw' | 'w' export type TooltipProps = React.PropsWithChildren< { direction?: TooltipDirection @@ -133,7 +133,7 @@ export type TooltipProps = React.PropsWithChildren< ComponentProps > -export type TriggerPropsType = { +type TriggerPropsType = { 'aria-describedby'?: string 'aria-labelledby'?: string 'aria-label'?: string diff --git a/packages/react/src/__tests__/__snapshots__/exports.test.ts.snap b/packages/react/src/__tests__/__snapshots__/exports.test.ts.snap index dd5d8d91184..755b253d9d5 100644 --- a/packages/react/src/__tests__/__snapshots__/exports.test.ts.snap +++ b/packages/react/src/__tests__/__snapshots__/exports.test.ts.snap @@ -316,8 +316,6 @@ exports[`@primer/react/experimental should not update exports without a semver c "type TableTitleProps", "type TitleProps", "Tooltip", - "TooltipContext", - "type TooltipDirection", "type TooltipProps", "type TriggerPropsType", "UnderlinePanels", diff --git a/packages/react/src/experimental/index.ts b/packages/react/src/experimental/index.ts index f131cf11e6b..d4db2e4ccba 100644 --- a/packages/react/src/experimental/index.ts +++ b/packages/react/src/experimental/index.ts @@ -52,7 +52,8 @@ export type { NavListDividerProps, } from '../NavList' export * from './SelectPanel2' -export * from '../TooltipV2' +export {Tooltip} from '../TooltipV2' +export type {TooltipProps} from '../TooltipV2' export * from '../ActionBar' export {ScrollableRegion} from '../ScrollableRegion' From 75a826c5d76042ea922be65e7fed4d1aad3571d2 Mon Sep 17 00:00:00 2001 From: Armagan Ersoz Date: Fri, 4 Oct 2024 11:18:50 +1000 Subject: [PATCH 2/5] export tooltip direction for button --- packages/react/src/TooltipV2/Tooltip.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/TooltipV2/Tooltip.tsx b/packages/react/src/TooltipV2/Tooltip.tsx index 6a291be878a..3f613d340a2 100644 --- a/packages/react/src/TooltipV2/Tooltip.tsx +++ b/packages/react/src/TooltipV2/Tooltip.tsx @@ -123,7 +123,7 @@ const StyledTooltip = styled.span` ${sx}; ` -type TooltipDirection = 'nw' | 'n' | 'ne' | 'e' | 'se' | 's' | 'sw' | 'w' +export type TooltipDirection = 'nw' | 'n' | 'ne' | 'e' | 'se' | 's' | 'sw' | 'w' export type TooltipProps = React.PropsWithChildren< { direction?: TooltipDirection From 079656db98899b3baa01047adce34a50ea9cece5 Mon Sep 17 00:00:00 2001 From: Armagan Ersoz Date: Fri, 4 Oct 2024 11:49:23 +1000 Subject: [PATCH 3/5] snapshot --- packages/react/src/__tests__/__snapshots__/exports.test.ts.snap | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/react/src/__tests__/__snapshots__/exports.test.ts.snap b/packages/react/src/__tests__/__snapshots__/exports.test.ts.snap index 755b253d9d5..84cd54b066c 100644 --- a/packages/react/src/__tests__/__snapshots__/exports.test.ts.snap +++ b/packages/react/src/__tests__/__snapshots__/exports.test.ts.snap @@ -317,7 +317,6 @@ exports[`@primer/react/experimental should not update exports without a semver c "type TitleProps", "Tooltip", "type TooltipProps", - "type TriggerPropsType", "UnderlinePanels", "type UnderlinePanelsPanelProps", "type UnderlinePanelsProps", From 014e73d1073d0ff6da1a545a55de141a70fc7e84 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Arma=C4=9Fan?= Date: Fri, 4 Oct 2024 14:34:12 +1000 Subject: [PATCH 4/5] Create eight-avocados-lick.md --- .changeset/eight-avocados-lick.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/eight-avocados-lick.md diff --git a/.changeset/eight-avocados-lick.md b/.changeset/eight-avocados-lick.md new file mode 100644 index 00000000000..c3e2226f06a --- /dev/null +++ b/.changeset/eight-avocados-lick.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +Tooltip: Do not export all types publicly in the experimental bundle From fa0b38a9c113a891af4a50f7325d127ee5297abf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Arma=C4=9Fan?= Date: Tue, 8 Oct 2024 09:16:16 +1000 Subject: [PATCH 5/5] Update .changeset/eight-avocados-lick.md --- .changeset/eight-avocados-lick.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/eight-avocados-lick.md b/.changeset/eight-avocados-lick.md index c3e2226f06a..5b98b3dba35 100644 --- a/.changeset/eight-avocados-lick.md +++ b/.changeset/eight-avocados-lick.md @@ -1,5 +1,5 @@ --- -"@primer/react": patch +"@primer/react": minor --- Tooltip: Do not export all types publicly in the experimental bundle