From eb288b6fe150befaf675a59fb8118092ee42ded2 Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Tue, 17 Sep 2024 11:36:36 +0200 Subject: [PATCH 1/2] add role=combobox to filter input --- .../FilteredActionListWithModernActionList.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/react/src/FilteredActionList/FilteredActionListWithModernActionList.tsx b/packages/react/src/FilteredActionList/FilteredActionListWithModernActionList.tsx index ae791e63909..b0a90f7141a 100644 --- a/packages/react/src/FilteredActionList/FilteredActionListWithModernActionList.tsx +++ b/packages/react/src/FilteredActionList/FilteredActionListWithModernActionList.tsx @@ -138,8 +138,11 @@ export function FilteredActionList({ onChange={onInputChange} onKeyPress={onInputKeyPress} placeholder={placeholderText} - aria-label={placeholderText} + role="combobox" + aria-expanded="true" + aria-autocomplete="list" aria-controls={listId} + aria-label={placeholderText} aria-describedby={inputDescriptionTextId} {...textInputProps} /> From 09631b7616533805fdee80a967a3acb5f7987542 Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Tue, 17 Sep 2024 12:13:16 +0200 Subject: [PATCH 2/2] Create selectpanel-combobox.md --- .changeset/green-poems-play.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/green-poems-play.md diff --git a/.changeset/green-poems-play.md b/.changeset/green-poems-play.md new file mode 100644 index 00000000000..6bad5c2a0a2 --- /dev/null +++ b/.changeset/green-poems-play.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +SelectPanel: Add `role=combobox` to filter input (behind feature flag `primer_react_select_panel_with_modern_action_list`)