From 2978fac5e8bad817858191f99cec02174a2e40cb Mon Sep 17 00:00:00 2001 From: langermank <18661030+langermank@users.noreply.github.com> Date: Thu, 14 Mar 2024 09:03:28 -0700 Subject: [PATCH 1/3] make bold --- packages/react/src/ActionList/Item.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/src/ActionList/Item.tsx b/packages/react/src/ActionList/Item.tsx index 140ceeb6e20..b743d975848 100644 --- a/packages/react/src/ActionList/Item.tsx +++ b/packages/react/src/ActionList/Item.tsx @@ -319,7 +319,7 @@ export const Item = React.forwardRef( id={labelId} sx={{ flexGrow: slots.inlineDescription ? 0 : 1, - fontWeight: slots.inlineDescription || slots.blockDescription ? 'bold' : 'normal', + fontWeight: slots.inlineDescription || slots.blockDescription || active ? 'bold' : 'normal', marginBlockEnd: slots.blockDescription ? '4px' : undefined, }} > From e5828c8ec6d34b29725818a553735815146571e0 Mon Sep 17 00:00:00 2001 From: Katie Langerman <18661030+langermank@users.noreply.github.com> Date: Thu, 14 Mar 2024 09:22:44 -0700 Subject: [PATCH 2/3] Create wicked-rings-lay.md --- .changeset/wicked-rings-lay.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/wicked-rings-lay.md diff --git a/.changeset/wicked-rings-lay.md b/.changeset/wicked-rings-lay.md new file mode 100644 index 00000000000..2cfc1fa0f5b --- /dev/null +++ b/.changeset/wicked-rings-lay.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +Bug fix: make `active` label bold in ActionList From d72c78d2b37e6aafcb687a915ae39806b41f717a Mon Sep 17 00:00:00 2001 From: langermank <18661030+langermank@users.noreply.github.com> Date: Fri, 22 Mar 2024 14:54:46 -0700 Subject: [PATCH 3/3] snaps --- .../__snapshots__/NavList.test.tsx.snap | 52 ++++++++++++++----- 1 file changed, 38 insertions(+), 14 deletions(-) diff --git a/packages/react/src/NavList/__snapshots__/NavList.test.tsx.snap b/packages/react/src/NavList/__snapshots__/NavList.test.tsx.snap index 7acbe0c4963..2ed70b0023f 100644 --- a/packages/react/src/NavList/__snapshots__/NavList.test.tsx.snap +++ b/packages/react/src/NavList/__snapshots__/NavList.test.tsx.snap @@ -17,6 +17,14 @@ exports[`NavList renders a simple list 1`] = ` } .c6 { + -webkit-box-flex: 1; + -webkit-flex-grow: 1; + -ms-flex-positive: 1; + flex-grow: 1; + font-weight: 600; +} + +.c8 { -webkit-box-flex: 1; -webkit-flex-grow: 1; -ms-flex-positive: 1; @@ -357,7 +365,7 @@ exports[`NavList renders a simple list 1`] = ` data-component="ActionList.Item--DividerContainer" > About @@ -380,7 +388,7 @@ exports[`NavList renders a simple list 1`] = ` data-component="ActionList.Item--DividerContainer" > Contact @@ -434,6 +442,14 @@ exports[`NavList renders with groups 1`] = ` } .c10 { + -webkit-box-flex: 1; + -webkit-flex-grow: 1; + -ms-flex-positive: 1; + flex-grow: 1; + font-weight: 600; +} + +.c12 { -webkit-box-flex: 1; -webkit-flex-grow: 1; -ms-flex-positive: 1; @@ -825,7 +841,7 @@ exports[`NavList renders with groups 1`] = ` data-component="ActionList.Item--DividerContainer" > Avatar @@ -894,6 +910,14 @@ exports[`NavList.Item with NavList.SubNav does not have active styles if SubNav color: var(--fgColor-default,var(--color-fg-default,#1F2328)); } +.c14 { + -webkit-box-flex: 1; + -webkit-flex-grow: 1; + -ms-flex-positive: 1; + flex-grow: 1; + font-weight: 600; +} + .c10 { padding: 0; margin: 0; @@ -917,8 +941,8 @@ exports[`NavList.Item with NavList.SubNav does not have active styles if SubNav --divider-color: transparent !important; } -.c14:hover:not([aria-disabled]):not([data-inactive]) + .c3, -.c14[data-focus-visible-added] + li { +.c15:hover:not([aria-disabled]):not([data-inactive]) + .c3, +.c15[data-focus-visible-added] + li { --divider-color: transparent; } @@ -1287,7 +1311,7 @@ exports[`NavList.Item with NavList.SubNav does not have active styles if SubNav data-component="ActionList.Item--DividerContainer" > Sub Item @@ -1334,14 +1358,6 @@ exports[`NavList.Item with NavList.SubNav has active styles if SubNav contains t flex-grow: 1; } -.c7 { - -webkit-box-flex: 1; - -webkit-flex-grow: 1; - -ms-flex-positive: 1; - flex-grow: 1; - font-weight: 400; -} - .c8 { height: 20px; -webkit-flex-shrink: 0; @@ -1363,6 +1379,14 @@ exports[`NavList.Item with NavList.SubNav has active styles if SubNav contains t display: none; } +.c7 { + -webkit-box-flex: 1; + -webkit-flex-grow: 1; + -ms-flex-positive: 1; + flex-grow: 1; + font-weight: 600; +} + .c9 { -webkit-transform: rotate(0deg); -ms-transform: rotate(0deg);