Skip to content

Conversation

@broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Mar 12, 2024

Reintroducing #4156 since we reverted it to make a solo release with PVC

Updating the existing tooltip to match with the new tooltip styles. We need this because we won't be able to update all tooltips at dotcom to use the new version and we don't want style inconsistencies. We will do the same update on rails and css and coordinate a release together. Working with @langermank on this together.

Changelog

New

Changed

Removed

  • Caret of the tooltip is removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Please view the stories https://primer-5fae3091a4-13348165.drafts.github.io/storybook/?path=/story/components-tooltip--default and confirm that the caret is not present and the design matches with the updated styles

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2024

🦋 Changeset detected

Latest commit: 7e7e054

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@broccolinisoup broccolinisoup changed the title reintroduce tooltip v1 Tooltip v1: (Reintroduced PR) - Remove the caret from the tooltip to make it consistent with the new tooltip Mar 12, 2024
@broccolinisoup broccolinisoup marked this pull request as ready for review March 12, 2024 05:43
@broccolinisoup broccolinisoup requested a review from a team as a code owner March 12, 2024 05:43
@github-actions
Copy link
Contributor

github-actions bot commented Mar 12, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 87.51 KB (-0.07% 🔽)
packages/react/dist/browser.umd.js 87.74 KB (-0.25% 🔽)

@joshblack joshblack added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit a392556 Mar 13, 2024
@joshblack joshblack deleted the re-introduce-tooltip-v1-visual branch March 13, 2024 22:24
@primer primer bot mentioned this pull request Mar 13, 2024
lukasoppermann pushed a commit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants