Skip to content

Conversation

@joshblack
Copy link
Member

Closes #4344

Changelog

New

Changed

  • Change default color of icon button to use fg.muted

Removed

Rollout strategy

  • Minor release

Testing & Reviewing

  • Verify that the icon button uses fg.muted as the color

@joshblack joshblack requested a review from a team as a code owner March 6, 2024 21:59
@changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2024

🦋 Changeset detected

Latest commit: d9e62bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89 KB (-0.12% 🔽)
packages/react/dist/browser.umd.js 89.3 KB (-0.07% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4364 March 6, 2024 22:04 Inactive
@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 6, 2024
@joshblack joshblack requested a review from jonrohan March 6, 2024 22:11
@github-actions github-actions bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 6, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4364 March 6, 2024 22:20 Inactive
@joshblack joshblack added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Mar 11, 2024
@joshblack joshblack added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Mar 11, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4364 March 11, 2024 14:43 Inactive
@joshblack joshblack added this pull request to the merge queue Mar 12, 2024
Merged via the queue into main with commit 2f65ea5 Mar 12, 2024
@joshblack joshblack deleted the 4344-icon-button-color branch March 12, 2024 20:05
@primer primer bot mentioned this pull request Mar 12, 2024
lukasoppermann pushed a commit that referenced this pull request Apr 16, 2024
* fix(button): update icon only button styles to use fg muted

* chore: add changeset

* test(vrt): update snapshots

* test: update snapshots

* test(vrt): update snapshots

---------

Co-authored-by: Josh Black <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IconButton is using color fg.default instead of fg.muted

4 participants