From 2255ddfac60ee97ab6e378fac78647f8297db012 Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Tue, 5 Mar 2024 15:58:37 +0100 Subject: [PATCH 1/3] remove aria-label attribute from TextInput.Action --- .../internal/components/TextInputInnerAction.tsx | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/packages/react/src/internal/components/TextInputInnerAction.tsx b/packages/react/src/internal/components/TextInputInnerAction.tsx index 26b1ae22a33..93ce1b7ba93 100644 --- a/packages/react/src/internal/components/TextInputInnerAction.tsx +++ b/packages/react/src/internal/components/TextInputInnerAction.tsx @@ -96,17 +96,8 @@ const TextInputAction = forwardRef( {icon && !children ? ( - + {/* @ts-ignore we intentionally do add aria-label to IconButton because Tooltip v2 adds an aria-labelledby instead. */} + ) : ( From a74b3535ef95ee46bb197d7c1eb6be88d2de383a Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Tue, 5 Mar 2024 16:19:32 +0100 Subject: [PATCH 2/3] update snapshot --- .../react/src/__tests__/__snapshots__/TextInput.test.tsx.snap | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/react/src/__tests__/__snapshots__/TextInput.test.tsx.snap b/packages/react/src/__tests__/__snapshots__/TextInput.test.tsx.snap index ccae5e08073..eac498de8a1 100644 --- a/packages/react/src/__tests__/__snapshots__/TextInput.test.tsx.snap +++ b/packages/react/src/__tests__/__snapshots__/TextInput.test.tsx.snap @@ -2177,7 +2177,6 @@ exports[`TextInput renders trailingAction icon button 1`] = ` className="c3 TextInput-action" >