From 236d1821d0139ec5e7fddf0b6301c66631c23878 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 29 Jan 2024 02:43:12 +0000 Subject: [PATCH 1/3] chore(deps): bump @github/combobox-nav from 2.1.7 to 2.3.1 Bumps [@github/combobox-nav](https://github.com/github/combobox-nav) from 2.1.7 to 2.3.1. - [Release notes](https://github.com/github/combobox-nav/releases) - [Commits](https://github.com/github/combobox-nav/compare/v2.1.7...v2.3.1) --- updated-dependencies: - dependency-name: "@github/combobox-nav" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- package-lock.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/package-lock.json b/package-lock.json index 4dd94743758..23a51c6ec7c 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@primer/react", - "version": "36.5.0", + "version": "36.6.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@primer/react", - "version": "36.5.0", + "version": "36.6.0", "license": "MIT", "dependencies": { "@github/combobox-nav": "^2.1.5", @@ -4161,9 +4161,9 @@ "dev": true }, "node_modules/@github/combobox-nav": { - "version": "2.1.7", - "resolved": "https://registry.npmjs.org/@github/combobox-nav/-/combobox-nav-2.1.7.tgz", - "integrity": "sha512-Webx0W5iTpkk5Chy9dB/1BEUORQ0qrwui8HaaVBiy75W2VOJg96WTuKj1rXENAJ3XTMhdEF53bn0LYfvP0EKvg==" + "version": "2.3.1", + "resolved": "https://registry.npmjs.org/@github/combobox-nav/-/combobox-nav-2.3.1.tgz", + "integrity": "sha512-gwxPzLw8XKecy1nP63i9lOBritS3bWmxl02UX6G0TwMQZbMem1BCS1tEZgYd3mkrkiDrUMWaX+DbFCuDFo3K+A==" }, "node_modules/@github/details-menu-element": { "version": "1.0.13", From d8e6c7508d4fe120d62625c4e010f008328977a0 Mon Sep 17 00:00:00 2001 From: Josh Black Date: Mon, 29 Jan 2024 11:10:03 -0600 Subject: [PATCH 2/3] test: add fallback for Element#scrollIntoView --- src/utils/test-helpers.tsx | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/utils/test-helpers.tsx b/src/utils/test-helpers.tsx index 05b286d06b0..af14032461c 100644 --- a/src/utils/test-helpers.tsx +++ b/src/utils/test-helpers.tsx @@ -37,3 +37,9 @@ if (typeof document !== 'undefined') { this.open = false }) } + +// Add a fallback for scrollIntoView if it does not exist in the test +// environment +if (global.Element.prototype.scrollIntoView === undefined) { + global.Element.prototype.scrollIntoView = jest.fn() +} From d1fd4fc80279edeeb8d6594c8a2b756242d595f4 Mon Sep 17 00:00:00 2001 From: Josh Black Date: Mon, 29 Jan 2024 11:19:37 -0600 Subject: [PATCH 3/3] chore: fix eslint warning --- src/utils/test-helpers.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/utils/test-helpers.tsx b/src/utils/test-helpers.tsx index af14032461c..056c4c17e76 100644 --- a/src/utils/test-helpers.tsx +++ b/src/utils/test-helpers.tsx @@ -39,7 +39,8 @@ if (typeof document !== 'undefined') { } // Add a fallback for scrollIntoView if it does not exist in the test -// environment +// environment. +// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition if (global.Element.prototype.scrollIntoView === undefined) { global.Element.prototype.scrollIntoView = jest.fn() }