Tooltip v1: Remove the caret from the tooltip to make it consistent with the new tooltip, css and rails - Do not merge #4156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6a74003 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
broccolinisoup
changed the title
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
added
the
update snapshots
Contributor
|
I think we may have also removed the animations/delay. I can't suggest to remove it because it wasn't edited here 😄 
|
github-actions
bot
removed
the
update snapshots
Member
Author
Good point! We still have the animation in the v2 but no delay. I vaguely remember that we removed the animation and it was too snappy so we kept it. |
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
langermank
approved these changes
Feb 13, 2024
joshblack
approved these changes
Feb 21, 2024
broccolinisoup
commented
Mar 3, 2024
Merged
13 tasks
13 tasks
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
…ith the new tooltip, css and rails - Do not merge (#4156) * Tooltip v1: Remove the caret * update the border radius * snaps * test(vrt): update snapshots * do not delay the animation * fix up conflict issue snapshot * Update .changeset/rotten-schools-whisper.md --------- Co-authored-by: langermank <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Updating the existing tooltip to match with the new tooltip styles. We need this because we won't be able to update all tooltips at dotcom to use the new version and we don't want style inconsistencies. We will do the same update on rails and css and coordinate a release together. Working with @langermank on this together.
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Please view the stories https://primer-5fae3091a4-13348165.drafts.github.io/storybook/?path=/story/components-tooltip--default and confirm that the caret is not present and the design matches with the updated styles
Merge checklist