From 4c7f4778bc86ba25503f7b59ca381c5e71e49faa Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 19 Dec 2023 18:43:50 +0000 Subject: [PATCH 1/3] chore(deps-dev): bump @types/react from 18.2.21 to 18.2.45 Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.2.21 to 18.2.45. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] --- package-lock.json | 12 ++++++------ package.json | 2 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/package-lock.json b/package-lock.json index fc0bb2474ee..88896227c9a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@primer/react", - "version": "36.4.0", + "version": "36.5.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@primer/react", - "version": "36.4.0", + "version": "36.5.0", "license": "MIT", "dependencies": { "@github/combobox-nav": "^2.1.5", @@ -92,7 +92,7 @@ "@types/lodash.isobject": "3.0.7", "@types/lodash.keyby": "4.6.7", "@types/node": "20.10.3", - "@types/react": "18.2.21", + "@types/react": "18.2.45", "@types/react-dom": "18.2.6", "@types/semver": "7.5.3", "@types/styled-components": "^5.1.26", @@ -13606,9 +13606,9 @@ "dev": true }, "node_modules/@types/react": { - "version": "18.2.21", - "resolved": "https://registry.npmjs.org/@types/react/-/react-18.2.21.tgz", - "integrity": "sha512-neFKG/sBAwGxHgXiIxnbm3/AAVQ/cMRS93hvBpg8xYRbeQSPVABp9U2bRnPf0iI4+Ucdv3plSxKK+3CW2ENJxA==", + "version": "18.2.45", + "resolved": "https://registry.npmjs.org/@types/react/-/react-18.2.45.tgz", + "integrity": "sha512-TtAxCNrlrBp8GoeEp1npd5g+d/OejJHFxS3OWmrPBMFaVQMSN0OFySozJio5BHxTuTeug00AVXVAjfDSfk+lUg==", "dependencies": { "@types/prop-types": "*", "@types/scheduler": "*", diff --git a/package.json b/package.json index 32b18c7a7e7..2137b43e67d 100644 --- a/package.json +++ b/package.json @@ -177,7 +177,7 @@ "@types/lodash.isobject": "3.0.7", "@types/lodash.keyby": "4.6.7", "@types/node": "20.10.3", - "@types/react": "18.2.21", + "@types/react": "18.2.45", "@types/react-dom": "18.2.6", "@types/semver": "7.5.3", "@types/styled-components": "^5.1.26", From 2e88bee83d2af83cd3dba121f84316cbec3a571f Mon Sep 17 00:00:00 2001 From: Josh Black Date: Tue, 19 Dec 2023 12:18:30 -0700 Subject: [PATCH 2/3] fix(Select): add placeholder prop --- src/Select.tsx | 4 +++- src/Select/Select.tsx | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/Select.tsx b/src/Select.tsx index 74c9d4608fb..f1297f94650 100644 --- a/src/Select.tsx +++ b/src/Select.tsx @@ -6,7 +6,9 @@ import {SxProp, merge, BetterSystemStyleObject} from './sx' export type SelectProps = Omit< Omit, 'size'> & Omit, 'multiple' | 'hasLeadingVisual' | 'hasTrailingVisual' | 'as' -> +> & { + placeholder?: string +} const arrowRightOffset = '4px' diff --git a/src/Select/Select.tsx b/src/Select/Select.tsx index 36bcdb33fbd..247aae714eb 100644 --- a/src/Select/Select.tsx +++ b/src/Select/Select.tsx @@ -5,7 +5,9 @@ import TextInputWrapper, {StyledWrapperProps} from '../internal/components/TextI export type SelectProps = Omit< Omit, 'size'> & Omit, 'multiple' | 'hasLeadingVisual' | 'hasTrailingVisual' | 'as' -> +> & { + placeholder?: string +} const arrowRightOffset = '4px' From dc8690f11f3185addf4d7f145dcab8f6fe7f4e5c Mon Sep 17 00:00:00 2001 From: Josh Black Date: Tue, 19 Dec 2023 12:18:53 -0700 Subject: [PATCH 3/3] chore: add changeset --- .changeset/tame-pandas-tie.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/tame-pandas-tie.md diff --git a/.changeset/tame-pandas-tie.md b/.changeset/tame-pandas-tie.md new file mode 100644 index 00000000000..bbf010de6db --- /dev/null +++ b/.changeset/tame-pandas-tie.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Update types for Select to include `placeholder`