From 32ffe24f6f37d142a29e74d90104cd5d2475e73a Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 15 Aug 2023 14:08:03 -0400 Subject: [PATCH 01/21] Added InlineAutocomplete stories --- src/__tests__/storybook.test.tsx | 1 + src/drafts/InlineAutocomplete/InlineAutocomplete.stories.tsx | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/__tests__/storybook.test.tsx b/src/__tests__/storybook.test.tsx index ce7f8f509b5..94fc1cd7e26 100644 --- a/src/__tests__/storybook.test.tsx +++ b/src/__tests__/storybook.test.tsx @@ -26,6 +26,7 @@ const allowlist = [ 'Header', 'Heading', 'IconButton', + 'InlineAutocomplete', 'FilteredActionList', 'Link', 'Pagehead', diff --git a/src/drafts/InlineAutocomplete/InlineAutocomplete.stories.tsx b/src/drafts/InlineAutocomplete/InlineAutocomplete.stories.tsx index 94faa2a4e28..6481c713b5f 100644 --- a/src/drafts/InlineAutocomplete/InlineAutocomplete.stories.tsx +++ b/src/drafts/InlineAutocomplete/InlineAutocomplete.stories.tsx @@ -5,7 +5,7 @@ import {BaseStyles, Box, Textarea, ThemeProvider, FormControl} from '../..' import InlineAutocomplete, {ShowSuggestionsEvent, Suggestions} from '.' export default { - title: 'Components/Forms/InlineAutocomplete', + title: 'Drafts/Components/InlineAutocomplete', component: InlineAutocomplete, decorators: [ Story => { From 641d1e5c3820f46b478412db50313efc5d2de3be Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Wed, 23 Aug 2023 12:16:17 -0400 Subject: [PATCH 02/21] fix story naming convention and merge main --- src/FormControl/FormControl.tsx | 2 +- .../InlineAutocomplete.docs.json | 0 .../InlineAutocomplete.features.stories.tsx | 4 ++-- .../InlineAutocomplete.stories.tsx | 4 ++-- .../InlineAutocomplete/InlineAutocomplete.test.tsx | 8 ++++---- .../InlineAutocomplete/InlineAutocomplete.tsx | 12 ++++++------ .../_AutocompleteSuggestions.tsx | 14 +++++++------- src/{drafts => }/InlineAutocomplete/index.ts | 0 src/{drafts => }/InlineAutocomplete/types.ts | 2 +- src/{drafts => }/InlineAutocomplete/utils.ts | 0 src/drafts/MarkdownEditor/_MarkdownInput.tsx | 2 +- .../suggestions/_useEmojiSuggestions.tsx | 2 +- .../suggestions/_useMentionSuggestions.tsx | 2 +- .../suggestions/_useReferenceSuggestions.tsx | 2 +- src/drafts/MarkdownEditor/suggestions/index.ts | 2 +- src/drafts/index.ts | 4 ++-- 16 files changed, 30 insertions(+), 30 deletions(-) rename src/{drafts => }/InlineAutocomplete/InlineAutocomplete.docs.json (100%) rename src/{drafts => }/InlineAutocomplete/InlineAutocomplete.features.stories.tsx (98%) rename src/{drafts => }/InlineAutocomplete/InlineAutocomplete.stories.tsx (98%) rename src/{drafts => }/InlineAutocomplete/InlineAutocomplete.test.tsx (98%) rename src/{drafts => }/InlineAutocomplete/InlineAutocomplete.tsx (96%) rename src/{drafts => }/InlineAutocomplete/_AutocompleteSuggestions.tsx (92%) rename src/{drafts => }/InlineAutocomplete/index.ts (100%) rename src/{drafts => }/InlineAutocomplete/types.ts (96%) rename src/{drafts => }/InlineAutocomplete/utils.ts (100%) diff --git a/src/FormControl/FormControl.tsx b/src/FormControl/FormControl.tsx index 401029044ac..c390c8d2a64 100644 --- a/src/FormControl/FormControl.tsx +++ b/src/FormControl/FormControl.tsx @@ -10,7 +10,7 @@ import Textarea from '../Textarea' import {CheckboxOrRadioGroupContext} from '../internal/components/CheckboxOrRadioGroup' import ValidationAnimationContainer from '../internal/components/ValidationAnimationContainer' import {get} from '../constants' -import InlineAutocomplete from '../drafts/InlineAutocomplete' +import InlineAutocomplete from '../InlineAutocomplete' import {useSlots} from '../hooks/useSlots' import {SxProp} from '../sx' import {useId} from '../hooks/useId' diff --git a/src/drafts/InlineAutocomplete/InlineAutocomplete.docs.json b/src/InlineAutocomplete/InlineAutocomplete.docs.json similarity index 100% rename from src/drafts/InlineAutocomplete/InlineAutocomplete.docs.json rename to src/InlineAutocomplete/InlineAutocomplete.docs.json diff --git a/src/drafts/InlineAutocomplete/InlineAutocomplete.features.stories.tsx b/src/InlineAutocomplete/InlineAutocomplete.features.stories.tsx similarity index 98% rename from src/drafts/InlineAutocomplete/InlineAutocomplete.features.stories.tsx rename to src/InlineAutocomplete/InlineAutocomplete.features.stories.tsx index 3f2f9c5a6ae..dc147ec9119 100644 --- a/src/drafts/InlineAutocomplete/InlineAutocomplete.features.stories.tsx +++ b/src/InlineAutocomplete/InlineAutocomplete.features.stories.tsx @@ -1,10 +1,10 @@ import React, {useState} from 'react' import {Meta} from '@storybook/react' -import {ActionList, Avatar, ActionListItemProps, Textarea, TextInput, FormControl} from '../..' +import {ActionList, Avatar, ActionListItemProps, Textarea, TextInput, FormControl} from '..' import InlineAutocomplete, {ShowSuggestionsEvent, Suggestions} from '.' export default { - title: 'Components/Forms/InlineAutocomplete/Features', + title: 'Components/InlineAutocomplete/Features', component: InlineAutocomplete, } as Meta diff --git a/src/drafts/InlineAutocomplete/InlineAutocomplete.stories.tsx b/src/InlineAutocomplete/InlineAutocomplete.stories.tsx similarity index 98% rename from src/drafts/InlineAutocomplete/InlineAutocomplete.stories.tsx rename to src/InlineAutocomplete/InlineAutocomplete.stories.tsx index 6481c713b5f..25aba6560a1 100644 --- a/src/drafts/InlineAutocomplete/InlineAutocomplete.stories.tsx +++ b/src/InlineAutocomplete/InlineAutocomplete.stories.tsx @@ -1,11 +1,11 @@ import React, {useState} from 'react' import {Meta} from '@storybook/react' -import {BaseStyles, Box, Textarea, ThemeProvider, FormControl} from '../..' +import {BaseStyles, Box, Textarea, ThemeProvider, FormControl} from '..' import InlineAutocomplete, {ShowSuggestionsEvent, Suggestions} from '.' export default { - title: 'Drafts/Components/InlineAutocomplete', + title: 'Components/InlineAutocomplete', component: InlineAutocomplete, decorators: [ Story => { diff --git a/src/drafts/InlineAutocomplete/InlineAutocomplete.test.tsx b/src/InlineAutocomplete/InlineAutocomplete.test.tsx similarity index 98% rename from src/drafts/InlineAutocomplete/InlineAutocomplete.test.tsx rename to src/InlineAutocomplete/InlineAutocomplete.test.tsx index 5b090e5eb5d..c165f3d21ea 100644 --- a/src/drafts/InlineAutocomplete/InlineAutocomplete.test.tsx +++ b/src/InlineAutocomplete/InlineAutocomplete.test.tsx @@ -2,10 +2,10 @@ import React, {useLayoutEffect, useState} from 'react' import {fireEvent, render, within} from '@testing-library/react' import userEvent from '@testing-library/user-event' import InlineAutocomplete, {ShowSuggestionsEvent, Suggestions, Trigger} from '.' -import FormControl from '../../FormControl' -import {ActionList} from '../../ActionList' -import Textarea from '../../Textarea' -import ThemeProvider from '../../ThemeProvider' +import FormControl from '../FormControl' +import {ActionList} from '../ActionList' +import Textarea from '../Textarea' +import ThemeProvider from '../ThemeProvider' const label = 'Inline Autocomplete' diff --git a/src/drafts/InlineAutocomplete/InlineAutocomplete.tsx b/src/InlineAutocomplete/InlineAutocomplete.tsx similarity index 96% rename from src/drafts/InlineAutocomplete/InlineAutocomplete.tsx rename to src/InlineAutocomplete/InlineAutocomplete.tsx index f9d797823ad..1cd919e4b1d 100644 --- a/src/drafts/InlineAutocomplete/InlineAutocomplete.tsx +++ b/src/InlineAutocomplete/InlineAutocomplete.tsx @@ -1,9 +1,9 @@ import React, {cloneElement, useRef} from 'react' -import Box from '../../Box' -import Portal from '../../Portal' -import {BetterSystemStyleObject} from '../../sx' -import {useSyntheticChange} from '../hooks/useSyntheticChange' -import {getAbsoluteCharacterCoordinates} from '../utils/character-coordinates' +import Box from '../Box' +import Portal from '../Portal' +import {BetterSystemStyleObject} from '../sx' +import {useSyntheticChange} from '../drafts/hooks/useSyntheticChange' +import {getAbsoluteCharacterCoordinates} from '../drafts/utils/character-coordinates' import { ShowSuggestionsEvent, @@ -15,7 +15,7 @@ import { } from './types' import {augmentHandler, calculateSuggestionsQuery, getSuggestionValue, requireChildrenToBeInput} from './utils' -import {useRefObjectAsForwardedRef} from '../../hooks' +import {useRefObjectAsForwardedRef} from '../hooks' import AutocompleteSuggestions from './_AutocompleteSuggestions' export type InlineAutocompleteProps = { diff --git a/src/drafts/InlineAutocomplete/_AutocompleteSuggestions.tsx b/src/InlineAutocomplete/_AutocompleteSuggestions.tsx similarity index 92% rename from src/drafts/InlineAutocomplete/_AutocompleteSuggestions.tsx rename to src/InlineAutocomplete/_AutocompleteSuggestions.tsx index 3d9bdfa51c6..17be0fa857f 100644 --- a/src/drafts/InlineAutocomplete/_AutocompleteSuggestions.tsx +++ b/src/InlineAutocomplete/_AutocompleteSuggestions.tsx @@ -1,14 +1,14 @@ import React, {useCallback, useRef, useState} from 'react' -import Spinner from '../../Spinner' -import {ActionList, ActionListItemProps} from '../../ActionList' -import Box from '../../Box' -import {ComboboxCommitEvent, useCombobox} from '../hooks/useCombobox' -import Overlay from '../../Overlay' +import Spinner from '../Spinner' +import {ActionList, ActionListItemProps} from '../ActionList' +import Box from '../Box' +import {ComboboxCommitEvent, useCombobox} from '../drafts/hooks/useCombobox' +import Overlay from '../Overlay' import {Suggestion, Suggestions, SuggestionsPlacement, TextInputElement} from './types' import {getSuggestionKey, getSuggestionValue} from './utils' -import {CharacterCoordinates} from '../utils/character-coordinates' -import useIsomorphicLayoutEffect from '../../utils/useIsomorphicLayoutEffect' +import {CharacterCoordinates} from '../drafts/utils/character-coordinates' +import useIsomorphicLayoutEffect from '../utils/useIsomorphicLayoutEffect' type AutoCompleteSuggestionsProps = { suggestions: Suggestions | null diff --git a/src/drafts/InlineAutocomplete/index.ts b/src/InlineAutocomplete/index.ts similarity index 100% rename from src/drafts/InlineAutocomplete/index.ts rename to src/InlineAutocomplete/index.ts diff --git a/src/drafts/InlineAutocomplete/types.ts b/src/InlineAutocomplete/types.ts similarity index 96% rename from src/drafts/InlineAutocomplete/types.ts rename to src/InlineAutocomplete/types.ts index 2c4d22fb4f9..b9fc4454b84 100644 --- a/src/drafts/InlineAutocomplete/types.ts +++ b/src/InlineAutocomplete/types.ts @@ -1,4 +1,4 @@ -import {ActionListItemProps} from '../../ActionList' +import {ActionListItemProps} from '../ActionList' export type Trigger = { /** A single character that can cause the suggestion list to open. */ diff --git a/src/drafts/InlineAutocomplete/utils.ts b/src/InlineAutocomplete/utils.ts similarity index 100% rename from src/drafts/InlineAutocomplete/utils.ts rename to src/InlineAutocomplete/utils.ts diff --git a/src/drafts/MarkdownEditor/_MarkdownInput.tsx b/src/drafts/MarkdownEditor/_MarkdownInput.tsx index 9d0b7e4a9e5..da6c02d5103 100644 --- a/src/drafts/MarkdownEditor/_MarkdownInput.tsx +++ b/src/drafts/MarkdownEditor/_MarkdownInput.tsx @@ -1,7 +1,7 @@ import {subscribe as subscribeToMarkdownPasting} from '@github/paste-markdown' import React, {forwardRef, useEffect, useMemo, useRef, useState} from 'react' import {useDynamicTextareaHeight} from '../hooks/useDynamicTextareaHeight' -import InlineAutocomplete, {ShowSuggestionsEvent, Suggestions} from '../InlineAutocomplete' +import InlineAutocomplete, {ShowSuggestionsEvent, Suggestions} from '../../InlineAutocomplete' import Textarea, {TextareaProps} from '../../Textarea' import {Emoji, useEmojiSuggestions} from './suggestions/_useEmojiSuggestions' import {Mentionable, useMentionSuggestions} from './suggestions/_useMentionSuggestions' diff --git a/src/drafts/MarkdownEditor/suggestions/_useEmojiSuggestions.tsx b/src/drafts/MarkdownEditor/suggestions/_useEmojiSuggestions.tsx index 7c40dd82230..df1d74bb5ce 100644 --- a/src/drafts/MarkdownEditor/suggestions/_useEmojiSuggestions.tsx +++ b/src/drafts/MarkdownEditor/suggestions/_useEmojiSuggestions.tsx @@ -1,7 +1,7 @@ import React, {useMemo} from 'react' import {suggestionsCalculator, UseSuggestionsHook} from '.' import {ActionList} from '../../../ActionList' -import {Suggestion, Trigger} from '../../InlineAutocomplete' +import {Suggestion, Trigger} from '../../../InlineAutocomplete' type BaseEmoji = { /** Name (shortcode) of the emoji. Do not include the wrapping `:` symbols. */ diff --git a/src/drafts/MarkdownEditor/suggestions/_useMentionSuggestions.tsx b/src/drafts/MarkdownEditor/suggestions/_useMentionSuggestions.tsx index 386b4e4165e..8a9379029e8 100644 --- a/src/drafts/MarkdownEditor/suggestions/_useMentionSuggestions.tsx +++ b/src/drafts/MarkdownEditor/suggestions/_useMentionSuggestions.tsx @@ -2,7 +2,7 @@ import {score} from 'fzy.js' import React, {useMemo} from 'react' import {suggestionsCalculator, UseSuggestionsHook} from '.' import {ActionList} from '../../../ActionList' -import {Suggestion, Trigger} from '../../InlineAutocomplete' +import {Suggestion, Trigger} from '../../../InlineAutocomplete' import Text from '../../../Text' /** Could be a user, team, or organization - anything that can be mentioned. */ diff --git a/src/drafts/MarkdownEditor/suggestions/_useReferenceSuggestions.tsx b/src/drafts/MarkdownEditor/suggestions/_useReferenceSuggestions.tsx index efd97c4f582..2de5acb8350 100644 --- a/src/drafts/MarkdownEditor/suggestions/_useReferenceSuggestions.tsx +++ b/src/drafts/MarkdownEditor/suggestions/_useReferenceSuggestions.tsx @@ -1,7 +1,7 @@ import React, {useMemo} from 'react' import {suggestionsCalculator, UseSuggestionsHook} from '.' import {ActionList} from '../../../ActionList' -import {Suggestion, Trigger} from '../../InlineAutocomplete' +import {Suggestion, Trigger} from '../../../InlineAutocomplete' import Text from '../../../Text' import {score} from 'fzy.js' diff --git a/src/drafts/MarkdownEditor/suggestions/index.ts b/src/drafts/MarkdownEditor/suggestions/index.ts index a00939c8ffd..a3493c22d1f 100644 --- a/src/drafts/MarkdownEditor/suggestions/index.ts +++ b/src/drafts/MarkdownEditor/suggestions/index.ts @@ -1,4 +1,4 @@ -import {Suggestion, Trigger} from '../../InlineAutocomplete' +import {Suggestion, Trigger} from '../../../InlineAutocomplete' const MAX_SUGGESTIONS = 5 diff --git a/src/drafts/index.ts b/src/drafts/index.ts index 42e58458551..b127409954f 100644 --- a/src/drafts/index.ts +++ b/src/drafts/index.ts @@ -26,14 +26,14 @@ export type { export * from '../Dialog/Dialog' -export {default as InlineAutocomplete} from './InlineAutocomplete' +export {default as InlineAutocomplete} from '../InlineAutocomplete' export type { InlineAutocompleteProps, ShowSuggestionsEvent, Suggestion, Suggestions, Trigger, -} from './InlineAutocomplete' +} from '../InlineAutocomplete' export {default as MarkdownViewer} from './MarkdownViewer' export type {MarkdownViewerProps, InteractiveMarkdownViewerProps} from './MarkdownViewer' From 916bdf3b738262c5b3267d12b34b3b34f000e4d7 Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 5 Sep 2023 10:14:22 -0400 Subject: [PATCH 03/21] fix unrelated but breaking test --- src/__tests__/__snapshots__/RelativeTime.test.tsx.snap | 1 - 1 file changed, 1 deletion(-) diff --git a/src/__tests__/__snapshots__/RelativeTime.test.tsx.snap b/src/__tests__/__snapshots__/RelativeTime.test.tsx.snap index c2211076ba2..b1d5b1f082e 100644 --- a/src/__tests__/__snapshots__/RelativeTime.test.tsx.snap +++ b/src/__tests__/__snapshots__/RelativeTime.test.tsx.snap @@ -3,6 +3,5 @@ exports[`RelativeTime renders consistently 1`] = ` `; From f557d0825f2543fae117165d059cc1143bbb269f Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 5 Sep 2023 12:03:17 -0400 Subject: [PATCH 04/21] undo relative time update maybe --- src/__tests__/__snapshots__/RelativeTime.test.tsx.snap | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/__tests__/__snapshots__/RelativeTime.test.tsx.snap b/src/__tests__/__snapshots__/RelativeTime.test.tsx.snap index b1d5b1f082e..b1cb7c0c627 100644 --- a/src/__tests__/__snapshots__/RelativeTime.test.tsx.snap +++ b/src/__tests__/__snapshots__/RelativeTime.test.tsx.snap @@ -3,5 +3,6 @@ exports[`RelativeTime renders consistently 1`] = ` -`; +`; \ No newline at end of file From 5a47af02c80a209f336cdf32ae48022dbbd2c3d1 Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 5 Sep 2023 12:16:03 -0400 Subject: [PATCH 05/21] maybe this time --- src/__tests__/__snapshots__/RelativeTime.test.tsx.snap | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/__tests__/__snapshots__/RelativeTime.test.tsx.snap b/src/__tests__/__snapshots__/RelativeTime.test.tsx.snap index b1cb7c0c627..b1d5b1f082e 100644 --- a/src/__tests__/__snapshots__/RelativeTime.test.tsx.snap +++ b/src/__tests__/__snapshots__/RelativeTime.test.tsx.snap @@ -3,6 +3,5 @@ exports[`RelativeTime renders consistently 1`] = ` -`; \ No newline at end of file +`; From 06009bdfd2e128a87b3f748ff5a3b026d9d0708e Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Sun, 17 Sep 2023 21:02:45 -0400 Subject: [PATCH 06/21] fix import --- src/InlineAutocomplete/InlineAutocomplete.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/InlineAutocomplete/InlineAutocomplete.tsx b/src/InlineAutocomplete/InlineAutocomplete.tsx index 64cfe57778d..9f0c4f39fa0 100644 --- a/src/InlineAutocomplete/InlineAutocomplete.tsx +++ b/src/InlineAutocomplete/InlineAutocomplete.tsx @@ -18,7 +18,7 @@ import {augmentHandler, calculateSuggestionsQuery, getSuggestionValue, requireCh import {useRefObjectAsForwardedRef} from '../hooks' import AutocompleteSuggestions from './_AutocompleteSuggestions' -import {useFormControlForwardedProps} from '../../FormControl' +import {useFormControlForwardedProps} from '../FormControl' export type InlineAutocompleteProps = { /** Register the triggers that can cause suggestions to appear. */ From 298fc08aca7514031bcf0d48d2a021fb5b3186b7 Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Sun, 17 Sep 2023 21:08:33 -0400 Subject: [PATCH 07/21] more fix imports --- src/FormControl/FormControl.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/FormControl/FormControl.tsx b/src/FormControl/FormControl.tsx index f6301798063..3bfe0cfaa22 100644 --- a/src/FormControl/FormControl.tsx +++ b/src/FormControl/FormControl.tsx @@ -10,7 +10,6 @@ import Textarea from '../Textarea' import {CheckboxOrRadioGroupContext} from '../internal/components/CheckboxOrRadioGroup' import ValidationAnimationContainer from '../internal/components/ValidationAnimationContainer' import {get} from '../constants' -import InlineAutocomplete from '../InlineAutocomplete' import {useSlots} from '../hooks/useSlots' import {SxProp} from '../sx' import {useId} from '../hooks/useId' From 4c758b17279ace85c1d7914c7651dba54b8d97ea Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Sun, 17 Sep 2023 21:15:52 -0400 Subject: [PATCH 08/21] another fix imports --- docs/content/drafts/InlineAutocomplete.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/content/drafts/InlineAutocomplete.mdx b/docs/content/drafts/InlineAutocomplete.mdx index ed7b6c957ae..78683bcbf8b 100644 --- a/docs/content/drafts/InlineAutocomplete.mdx +++ b/docs/content/drafts/InlineAutocomplete.mdx @@ -7,7 +7,7 @@ source: https://github.com/primer/react/tree/main/src/InlineAutocomplete storybook: '/react/storybook?path=/story/components-forms-inlineautocomplete--default' --- -import data from '../../../src/drafts/InlineAutocomplete/InlineAutocomplete.docs.json' +import data from '../../src/drafts/InlineAutocomplete/InlineAutocomplete.docs.json' ```js import {InlineAutocomplete} from '@primer/react/drafts' From 04f9ef89011ac4ac08b5959449c3b2439f9da5c5 Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Sun, 17 Sep 2023 21:25:12 -0400 Subject: [PATCH 09/21] another fix imports --- docs/content/drafts/InlineAutocomplete.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/content/drafts/InlineAutocomplete.mdx b/docs/content/drafts/InlineAutocomplete.mdx index 78683bcbf8b..b10d4ead932 100644 --- a/docs/content/drafts/InlineAutocomplete.mdx +++ b/docs/content/drafts/InlineAutocomplete.mdx @@ -7,7 +7,7 @@ source: https://github.com/primer/react/tree/main/src/InlineAutocomplete storybook: '/react/storybook?path=/story/components-forms-inlineautocomplete--default' --- -import data from '../../src/drafts/InlineAutocomplete/InlineAutocomplete.docs.json' +import data from '../../../src/InlineAutocomplete/InlineAutocomplete.docs.json' ```js import {InlineAutocomplete} from '@primer/react/drafts' From 069cb5c4e5bc5af72b657d342430f625199e9cad Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Mon, 30 Oct 2023 09:46:13 -0400 Subject: [PATCH 10/21] fix: update playwright --- e2e/components/InlineAutocomplete.test.ts | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/e2e/components/InlineAutocomplete.test.ts b/e2e/components/InlineAutocomplete.test.ts index 19492e39cc3..eed04637281 100644 --- a/e2e/components/InlineAutocomplete.test.ts +++ b/e2e/components/InlineAutocomplete.test.ts @@ -8,7 +8,7 @@ test.describe('InlineAutocomplete', () => { test.describe(theme, () => { test('default @vrt', async ({page}) => { await visit(page, { - id: 'components-forms-inlineautocomplete--default', + id: 'components-inlineautocomplete--default', globals: { colorScheme: theme, }, @@ -20,7 +20,7 @@ test.describe('InlineAutocomplete', () => { test('axe @aat', async ({page}) => { await visit(page, { - id: 'components-forms-inlineautocomplete--default', + id: 'components-inlineautocomplete--default', globals: { colorScheme: theme, }, @@ -36,7 +36,7 @@ test.describe('InlineAutocomplete', () => { test.describe(theme, () => { test('default @vrt', async ({page}) => { await visit(page, { - id: 'components-forms-inlineautocomplete--playground', + id: 'components-inlineautocomplete--playground', globals: { colorScheme: theme, }, @@ -48,7 +48,7 @@ test.describe('InlineAutocomplete', () => { test('axe @aat', async ({page}) => { await visit(page, { - id: 'components-forms-inlineautocomplete--playground', + id: 'components-inlineautocomplete--playground', globals: { colorScheme: theme, }, @@ -64,7 +64,7 @@ test.describe('InlineAutocomplete', () => { test.describe(theme, () => { test('default @vrt', async ({page}) => { await visit(page, { - id: 'components-forms-inlineautocomplete-features--custom-rendering', + id: 'components-inlineautocomplete-features--custom-rendering', globals: { colorScheme: theme, }, @@ -76,7 +76,7 @@ test.describe('InlineAutocomplete', () => { test('axe @aat', async ({page}) => { await visit(page, { - id: 'components-forms-inlineautocomplete-features--custom-rendering', + id: 'components-inlineautocomplete-features--custom-rendering', globals: { colorScheme: theme, }, @@ -92,7 +92,7 @@ test.describe('InlineAutocomplete', () => { test.describe(theme, () => { test('default @vrt', async ({page}) => { await visit(page, { - id: 'components-forms-inlineautocomplete-features--single-line', + id: 'components-inlineautocomplete-features--single-line', globals: { colorScheme: theme, }, @@ -104,7 +104,7 @@ test.describe('InlineAutocomplete', () => { test('axe @aat', async ({page}) => { await visit(page, { - id: 'components-forms-inlineautocomplete-features--single-line', + id: 'components-inlineautocomplete-features--single-line', globals: { colorScheme: theme, }, From c226391c07008e1c2757710402508c46291cb005 Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 31 Oct 2023 09:41:20 -0400 Subject: [PATCH 11/21] Update docs/content/drafts/InlineAutocomplete.mdx MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Armağan --- docs/content/drafts/InlineAutocomplete.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/content/drafts/InlineAutocomplete.mdx b/docs/content/drafts/InlineAutocomplete.mdx index b10d4ead932..890d46ffefd 100644 --- a/docs/content/drafts/InlineAutocomplete.mdx +++ b/docs/content/drafts/InlineAutocomplete.mdx @@ -4,7 +4,7 @@ componentId: inline_autocomplete status: Draft description: Provides inline auto completion suggestions for an input or textarea. source: https://github.com/primer/react/tree/main/src/InlineAutocomplete -storybook: '/react/storybook?path=/story/components-forms-inlineautocomplete--default' +storybook: '/react/storybook?path=/story/drafts-components-inlineautocomplete--default' --- import data from '../../../src/InlineAutocomplete/InlineAutocomplete.docs.json' From e6cdc41b53cdd08f075859ba0275770841202e61 Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 31 Oct 2023 09:41:35 -0400 Subject: [PATCH 12/21] Update src/InlineAutocomplete/InlineAutocomplete.features.stories.tsx MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Armağan --- src/InlineAutocomplete/InlineAutocomplete.features.stories.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/InlineAutocomplete/InlineAutocomplete.features.stories.tsx b/src/InlineAutocomplete/InlineAutocomplete.features.stories.tsx index c46bda44733..0037a811e53 100644 --- a/src/InlineAutocomplete/InlineAutocomplete.features.stories.tsx +++ b/src/InlineAutocomplete/InlineAutocomplete.features.stories.tsx @@ -4,7 +4,7 @@ import {ActionList, Avatar, ActionListItemProps, Textarea, TextInput, FormContro import InlineAutocomplete, {ShowSuggestionsEvent, Suggestions} from '.' export default { - title: 'Components/InlineAutocomplete/Features', + title: 'Drafts/Components/InlineAutocomplete/Features', component: InlineAutocomplete, } as Meta From 4764ecb499097f78a69d3ca52c7650a69574e62f Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 31 Oct 2023 09:41:48 -0400 Subject: [PATCH 13/21] Update src/InlineAutocomplete/InlineAutocomplete.stories.tsx MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Armağan --- src/InlineAutocomplete/InlineAutocomplete.stories.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/InlineAutocomplete/InlineAutocomplete.stories.tsx b/src/InlineAutocomplete/InlineAutocomplete.stories.tsx index 25aba6560a1..d9762c3dd12 100644 --- a/src/InlineAutocomplete/InlineAutocomplete.stories.tsx +++ b/src/InlineAutocomplete/InlineAutocomplete.stories.tsx @@ -5,7 +5,7 @@ import {BaseStyles, Box, Textarea, ThemeProvider, FormControl} from '..' import InlineAutocomplete, {ShowSuggestionsEvent, Suggestions} from '.' export default { - title: 'Components/InlineAutocomplete', + title: 'Drafts/Components/InlineAutocomplete', component: InlineAutocomplete, decorators: [ Story => { From 7860ea9021fec62edcc49d216ae4f2770322d79d Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 31 Oct 2023 09:42:26 -0400 Subject: [PATCH 14/21] Update e2e/components/InlineAutocomplete.test.ts MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Armağan --- e2e/components/InlineAutocomplete.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e2e/components/InlineAutocomplete.test.ts b/e2e/components/InlineAutocomplete.test.ts index eed04637281..ed086c8caf3 100644 --- a/e2e/components/InlineAutocomplete.test.ts +++ b/e2e/components/InlineAutocomplete.test.ts @@ -8,7 +8,7 @@ test.describe('InlineAutocomplete', () => { test.describe(theme, () => { test('default @vrt', async ({page}) => { await visit(page, { - id: 'components-inlineautocomplete--default', + id: 'drafts-components-inlineautocomplete--default', globals: { colorScheme: theme, }, From 128a80ebd9064f226f858cf940cee95a246c172c Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 31 Oct 2023 11:43:43 -0400 Subject: [PATCH 15/21] Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Josh Black --- e2e/components/InlineAutocomplete.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e2e/components/InlineAutocomplete.test.ts b/e2e/components/InlineAutocomplete.test.ts index ed086c8caf3..55cb395acd7 100644 --- a/e2e/components/InlineAutocomplete.test.ts +++ b/e2e/components/InlineAutocomplete.test.ts @@ -20,7 +20,7 @@ test.describe('InlineAutocomplete', () => { test('axe @aat', async ({page}) => { await visit(page, { - id: 'components-inlineautocomplete--default', + id: 'drafts-components-inlineautocomplete--default', globals: { colorScheme: theme, }, From 3f00c8057eec23ad33c2f6cfbb42bd8eb30cfb7d Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 31 Oct 2023 11:43:50 -0400 Subject: [PATCH 16/21] Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Josh Black --- e2e/components/InlineAutocomplete.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e2e/components/InlineAutocomplete.test.ts b/e2e/components/InlineAutocomplete.test.ts index 55cb395acd7..c37f3524b9d 100644 --- a/e2e/components/InlineAutocomplete.test.ts +++ b/e2e/components/InlineAutocomplete.test.ts @@ -64,7 +64,7 @@ test.describe('InlineAutocomplete', () => { test.describe(theme, () => { test('default @vrt', async ({page}) => { await visit(page, { - id: 'components-inlineautocomplete-features--custom-rendering', + id: 'drafts-components-inlineautocomplete-features--custom-rendering', globals: { colorScheme: theme, }, From 2e6d66019c478134be91a35e489908da8b454de0 Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 31 Oct 2023 11:43:57 -0400 Subject: [PATCH 17/21] Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Josh Black --- e2e/components/InlineAutocomplete.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e2e/components/InlineAutocomplete.test.ts b/e2e/components/InlineAutocomplete.test.ts index c37f3524b9d..9871f1afc63 100644 --- a/e2e/components/InlineAutocomplete.test.ts +++ b/e2e/components/InlineAutocomplete.test.ts @@ -104,7 +104,7 @@ test.describe('InlineAutocomplete', () => { test('axe @aat', async ({page}) => { await visit(page, { - id: 'components-inlineautocomplete-features--single-line', + id: 'drafts-components-inlineautocomplete-features--single-line', globals: { colorScheme: theme, }, From 957a7b387018f66c1d7a0f89d2499ac9890c8c85 Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 31 Oct 2023 11:44:05 -0400 Subject: [PATCH 18/21] Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Josh Black --- e2e/components/InlineAutocomplete.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e2e/components/InlineAutocomplete.test.ts b/e2e/components/InlineAutocomplete.test.ts index 9871f1afc63..092d8c78d9d 100644 --- a/e2e/components/InlineAutocomplete.test.ts +++ b/e2e/components/InlineAutocomplete.test.ts @@ -92,7 +92,7 @@ test.describe('InlineAutocomplete', () => { test.describe(theme, () => { test('default @vrt', async ({page}) => { await visit(page, { - id: 'components-inlineautocomplete-features--single-line', + id: 'drafts-components-inlineautocomplete-features--single-line', globals: { colorScheme: theme, }, From e0a836eb5727afcfe774354dfcecd97a3e36444d Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 31 Oct 2023 11:44:13 -0400 Subject: [PATCH 19/21] Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Josh Black --- e2e/components/InlineAutocomplete.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e2e/components/InlineAutocomplete.test.ts b/e2e/components/InlineAutocomplete.test.ts index 092d8c78d9d..c02841ae6c7 100644 --- a/e2e/components/InlineAutocomplete.test.ts +++ b/e2e/components/InlineAutocomplete.test.ts @@ -76,7 +76,7 @@ test.describe('InlineAutocomplete', () => { test('axe @aat', async ({page}) => { await visit(page, { - id: 'components-inlineautocomplete-features--custom-rendering', + id: 'drafts-components-inlineautocomplete-features--custom-rendering', globals: { colorScheme: theme, }, From 0324e7eb34697b93092cb052973b7f3dc5e929df Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 31 Oct 2023 11:44:22 -0400 Subject: [PATCH 20/21] Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Josh Black --- e2e/components/InlineAutocomplete.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e2e/components/InlineAutocomplete.test.ts b/e2e/components/InlineAutocomplete.test.ts index c02841ae6c7..f2363c7ab4d 100644 --- a/e2e/components/InlineAutocomplete.test.ts +++ b/e2e/components/InlineAutocomplete.test.ts @@ -48,7 +48,7 @@ test.describe('InlineAutocomplete', () => { test('axe @aat', async ({page}) => { await visit(page, { - id: 'components-inlineautocomplete--playground', + id: 'drafts-components-inlineautocomplete--playground', globals: { colorScheme: theme, }, From ee92ddb45a23e288d1270022dad472c7cdf30ef1 Mon Sep 17 00:00:00 2001 From: Amanda Brown Date: Tue, 31 Oct 2023 11:44:29 -0400 Subject: [PATCH 21/21] Update e2e/components/InlineAutocomplete.test.ts Co-authored-by: Josh Black --- e2e/components/InlineAutocomplete.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/e2e/components/InlineAutocomplete.test.ts b/e2e/components/InlineAutocomplete.test.ts index f2363c7ab4d..84e4457990f 100644 --- a/e2e/components/InlineAutocomplete.test.ts +++ b/e2e/components/InlineAutocomplete.test.ts @@ -36,7 +36,7 @@ test.describe('InlineAutocomplete', () => { test.describe(theme, () => { test('default @vrt', async ({page}) => { await visit(page, { - id: 'components-inlineautocomplete--playground', + id: 'drafts-components-inlineautocomplete--playground', globals: { colorScheme: theme, },