diff --git a/.changeset/few-rocks-run.md b/.changeset/few-rocks-run.md new file mode 100644 index 00000000000..4a4276a6e9f --- /dev/null +++ b/.changeset/few-rocks-run.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Fixes type errors that appeared during v36 development. Likely caused by Button updates diff --git a/src/Token/TokenBase.tsx b/src/Token/TokenBase.tsx index 366a51edc04..a0ae3688b43 100644 --- a/src/Token/TokenBase.tsx +++ b/src/Token/TokenBase.tsx @@ -128,22 +128,25 @@ const StyledTokenBase = styled.span< ${sx} ` -const TokenBase = React.forwardRef(({onRemove, onKeyDown, id, size = defaultTokenSize, ...rest}, forwardedRef) => { - return ( - ) => { - onKeyDown && onKeyDown(event) +const TokenBase = React.forwardRef( + ({onRemove, onKeyDown, id, size = defaultTokenSize, ...rest}, forwardedRef) => { + return ( + ) => { + onKeyDown && onKeyDown(event) - if ((event.key === 'Backspace' || event.key === 'Delete') && onRemove) { - onRemove() - } - }} - id={id?.toString()} - size={size} - {...rest} - ref={forwardedRef} - /> - ) -}) as PolymorphicForwardRefComponent<'span' | 'a' | 'button', TokenBaseProps & SxProp> + if ((event.key === 'Backspace' || event.key === 'Delete') && onRemove) { + onRemove() + } + }} + id={id?.toString()} + size={size} + {...rest} + // @ts-expect-error TokenBase wants Anchor, Button, and Span refs + ref={forwardedRef} + /> + ) + }, +) as PolymorphicForwardRefComponent<'span' | 'a' | 'button', TokenBaseProps & SxProp> export default TokenBase diff --git a/src/drafts/Button2/types.ts b/src/drafts/Button2/types.ts index 7c92531816b..30c7a2ba555 100644 --- a/src/drafts/Button2/types.ts +++ b/src/drafts/Button2/types.ts @@ -20,7 +20,7 @@ type ButtonA11yProps = export type ButtonBaseProps = { /** - * Determine's the styles on a button one of 'default' | 'primary' | 'invisible' | 'danger' + * Determine's the styles on a button one of 'default' | 'primary' | 'invisible' | 'danger' | 'outline' */ variant?: VariantType /** diff --git a/src/drafts/MarkdownEditor/Actions.tsx b/src/drafts/MarkdownEditor/Actions.tsx index 25055e623b9..5cc8edfd847 100644 --- a/src/drafts/MarkdownEditor/Actions.tsx +++ b/src/drafts/MarkdownEditor/Actions.tsx @@ -1,5 +1,5 @@ import React, {forwardRef, useContext} from 'react' -import {Button, ButtonProps} from '../../Button' +import {Button, ButtonProps} from '../Button2' import {MarkdownEditorContext} from './_MarkdownEditorContext' export const Actions = ({children}: {children?: React.ReactNode}) => <>{children} diff --git a/src/drafts/MarkdownEditor/Footer.tsx b/src/drafts/MarkdownEditor/Footer.tsx index 3b23623c843..230c58b37c4 100644 --- a/src/drafts/MarkdownEditor/Footer.tsx +++ b/src/drafts/MarkdownEditor/Footer.tsx @@ -1,7 +1,8 @@ import React, {memo, forwardRef, useContext} from 'react' import {AlertIcon, ImageIcon, MarkdownIcon} from '@primer/octicons-react' -import {Spinner, Button, ButtonProps, LinkButton, Box, Text} from '../..' +import {Spinner, LinkButton, Box, Text} from '../..' +import {Button, ButtonProps} from '../Button2' import {MarkdownEditorContext} from './_MarkdownEditorContext' import {useSlots} from '../../hooks/useSlots' @@ -80,7 +81,7 @@ const FileUploadButton = memo(({fileDraggedOver, ...props}: Partial return (