From 2034c14784d30efe2d358cedaa7068da5309feaa Mon Sep 17 00:00:00 2001 From: Cole Bemis Date: Mon, 17 Oct 2022 14:19:45 -0700 Subject: [PATCH 1/2] Remove landmark elements from dialog --- src/Dialog/Dialog.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Dialog/Dialog.tsx b/src/Dialog/Dialog.tsx index e9850c35f6d..9337882794d 100644 --- a/src/Dialog/Dialog.tsx +++ b/src/Dialog/Dialog.tsx @@ -313,7 +313,7 @@ const _Dialog = React.forwardRef({as: 'header'})` +const Header = styled.div` box-shadow: 0 1px 0 ${get('colors.border.default')}; padding: ${get('space.2')}; z-index: 1; @@ -344,7 +344,7 @@ const Body = styled.div` ${sx}; ` -const Footer = styled.div.attrs({as: 'footer'})` +const Footer = styled.div` box-shadow: 0 -1px 0 ${get('colors.border.default')}; padding: ${get('space.3')}; display: flex; From 58c5884d999de0159053370982b508ef88275729 Mon Sep 17 00:00:00 2001 From: Cole Bemis Date: Mon, 17 Oct 2022 14:24:58 -0700 Subject: [PATCH 2/2] Create chatty-kangaroos-reply.md --- .changeset/chatty-kangaroos-reply.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/chatty-kangaroos-reply.md diff --git a/.changeset/chatty-kangaroos-reply.md b/.changeset/chatty-kangaroos-reply.md new file mode 100644 index 00000000000..c9a321ac881 --- /dev/null +++ b/.changeset/chatty-kangaroos-reply.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +Dialog: Remove landmark elements to improve accessibility