From 99d119239abbe8ed9a5a5a9790b88e5bf04f297f Mon Sep 17 00:00:00 2001 From: Matthew Costabile Date: Wed, 5 Oct 2022 07:31:52 -0400 Subject: [PATCH 1/2] correct types for markdown viewer label react 18 FC no longer has 'children' as implicit, so they must be defined separately --- src/drafts/MarkdownEditor/Label.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/drafts/MarkdownEditor/Label.tsx b/src/drafts/MarkdownEditor/Label.tsx index 926761bce70..5cc36a55485 100644 --- a/src/drafts/MarkdownEditor/Label.tsx +++ b/src/drafts/MarkdownEditor/Label.tsx @@ -6,6 +6,7 @@ import {MarkdownEditorContext} from './_MarkdownEditorContext' type LabelProps = SxProp & { visuallyHidden?: boolean + children?: React.ReactNode } // ref is not forwarded because InputLabel does not (yet) support it From 2c876f40eba4447c59c89c47d49c9d1cf6f2d06f Mon Sep 17 00:00:00 2001 From: Matthew Costabile Date: Wed, 5 Oct 2022 11:49:04 +0000 Subject: [PATCH 2/2] changeset --- .changeset/eleven-years-march.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/eleven-years-march.md diff --git a/.changeset/eleven-years-march.md b/.changeset/eleven-years-march.md new file mode 100644 index 00000000000..b3fe07af0e8 --- /dev/null +++ b/.changeset/eleven-years-march.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +fix react 18 typing for MarkdownEditor.Label