From 9ccd5c817dd62096d34f0e0fed55617ded7a1d94 Mon Sep 17 00:00:00 2001 From: Josh Black Date: Tue, 4 Oct 2022 12:56:45 -0500 Subject: [PATCH 1/3] fix(bundle): remove inline @github deps --- rollup.config.js | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/rollup.config.js b/rollup.config.js index ec58edd9d47..d6124961423 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -46,10 +46,10 @@ const baseConfig = { babelHelpers: 'inline', babelrc: false }), + commonjs(), resolve({ extensions - }), - commonjs() + }) ] } @@ -69,11 +69,7 @@ export default [ // CommonJS { ...baseConfig, - external: isExternal( - external.filter(id => { - return !id.startsWith('@github') - }) - ), + external: isExternal(external), output: { dir: 'lib', format: 'commonjs', From 1e10a6cc1d66ee1fdb7327cf8d9de3461d1c6dad Mon Sep 17 00:00:00 2001 From: Josh Black Date: Tue, 4 Oct 2022 12:57:42 -0500 Subject: [PATCH 2/3] chore: update package.json files --- package.json | 1 - 1 file changed, 1 deletion(-) diff --git a/package.json b/package.json index 26e56ca3e26..ad8d4d2010e 100644 --- a/package.json +++ b/package.json @@ -63,7 +63,6 @@ "codemods", "dist", "lib", - "lib/node_modules", "lib-esm", "index.d.ts", "drafts/package.json", From f2fc132759462f94d57e5161642f6fc6eb133b26 Mon Sep 17 00:00:00 2001 From: Josh Black Date: Tue, 4 Oct 2022 12:58:59 -0500 Subject: [PATCH 3/3] chore: add changeset --- .changeset/pink-jokes-destroy.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/pink-jokes-destroy.md diff --git a/.changeset/pink-jokes-destroy.md b/.changeset/pink-jokes-destroy.md new file mode 100644 index 00000000000..4fac49a0a2e --- /dev/null +++ b/.changeset/pink-jokes-destroy.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Update bundle to not inline @github dependencies