From 6f59045cb7716332c66616b665cf91a8210dd3ce Mon Sep 17 00:00:00 2001
From: Ian Sanders <iansan5653@github.com>
Date: Mon, 12 Sep 2022 19:49:59 +0000
Subject: [PATCH 1/4] Change `SelectPanel` footer to have consistent padding

---
 src/SelectPanel/SelectPanel.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/SelectPanel/SelectPanel.tsx b/src/SelectPanel/SelectPanel.tsx
index 1d39cd2765e..6870b684706 100644
--- a/src/SelectPanel/SelectPanel.tsx
+++ b/src/SelectPanel/SelectPanel.tsx
@@ -242,7 +242,7 @@ export function SelectPanel({
           alignItems="center"
           justifyContent="flex-end"
           gridGap="8px"
-          padding="12px"
+          p={2}
           borderTopColor="border.default"
           borderTopWidth={1}
           borderTopStyle="solid"

From 1db3c1bb3b49fe15ca7e40cca47df350ea59dbba Mon Sep 17 00:00:00 2001
From: Ian Sanders <iansan5653@github.com>
Date: Mon, 12 Sep 2022 19:52:03 +0000
Subject: [PATCH 2/4] Change `SelectPanel` header and footer to semantic
 elements

---
 src/SelectPanel/SelectPanel.tsx | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/SelectPanel/SelectPanel.tsx b/src/SelectPanel/SelectPanel.tsx
index 6870b684706..9b014150f0b 100644
--- a/src/SelectPanel/SelectPanel.tsx
+++ b/src/SelectPanel/SelectPanel.tsx
@@ -218,7 +218,7 @@ export function SelectPanel({
             ? 'No matching items'
             : `${items.length} matching ${items.length === 1 ? 'item' : 'items'}`}
         </VisuallyHidden>
-        <Box display="flex" alignItems="center" justifyContent="space-between" pl={3} pr={2} pt={2}>
+        <Box display="flex" alignItems="center" justifyContent="space-between" pl={3} pr={2} pt={2} as="header">
           <Heading as="h1" id={titleId} sx={{fontSize: 1}}>
             {title}
           </Heading>
@@ -246,6 +246,7 @@ export function SelectPanel({
           borderTopColor="border.default"
           borderTopWidth={1}
           borderTopStyle="solid"
+          as="footer"
         >
           <Button size="small" onClick={onCloseClickHandler}>
             Cancel

From b2b6111c16703a90a601c3dd33c3af4b8d306be1 Mon Sep 17 00:00:00 2001
From: Ian Sanders <iansan5653@github.com>
Date: Mon, 12 Sep 2022 19:52:38 +0000
Subject: [PATCH 3/4] Add `aria-modal` attribute to `SelectPanel` dialog

---
 src/SelectPanel/SelectPanel.tsx | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/SelectPanel/SelectPanel.tsx b/src/SelectPanel/SelectPanel.tsx
index 9b014150f0b..6c5a4fd5960 100644
--- a/src/SelectPanel/SelectPanel.tsx
+++ b/src/SelectPanel/SelectPanel.tsx
@@ -205,7 +205,13 @@ export function SelectPanel({
       open={open}
       onOpen={onOpen}
       onClose={onCloseOverlay}
-      overlayProps={{...overlayProps, onKeyPress: overlayKeyPressHandler, role: 'dialog', 'aria-labelledby': titleId}}
+      overlayProps={{
+        ...overlayProps,
+        onKeyPress: overlayKeyPressHandler,
+        role: 'dialog',
+        'aria-labelledby': titleId,
+        'aria-modal': true
+      }}
       focusTrapSettings={focusTrapSettings}
       focusZoneSettings={focusZoneSettings}
     >

From ffe6c0e3522c0b1dc4677de4682c3501e37c2a28 Mon Sep 17 00:00:00 2001
From: Ian Sanders <iansan5653@github.com>
Date: Mon, 12 Sep 2022 16:20:03 -0400
Subject: [PATCH 4/4] Create thirty-points-joke.md

---
 .changeset/thirty-points-joke.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/thirty-points-joke.md

diff --git a/.changeset/thirty-points-joke.md b/.changeset/thirty-points-joke.md
new file mode 100644
index 00000000000..3a0881da1b2
--- /dev/null
+++ b/.changeset/thirty-points-joke.md
@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+Minor fixes & adjustments for `SelectPanel`