diff --git a/.changeset/thirty-points-joke.md b/.changeset/thirty-points-joke.md new file mode 100644 index 00000000000..3a0881da1b2 --- /dev/null +++ b/.changeset/thirty-points-joke.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +Minor fixes & adjustments for `SelectPanel` diff --git a/src/SelectPanel/SelectPanel.tsx b/src/SelectPanel/SelectPanel.tsx index 1d39cd2765e..6c5a4fd5960 100644 --- a/src/SelectPanel/SelectPanel.tsx +++ b/src/SelectPanel/SelectPanel.tsx @@ -205,7 +205,13 @@ export function SelectPanel({ open={open} onOpen={onOpen} onClose={onCloseOverlay} - overlayProps={{...overlayProps, onKeyPress: overlayKeyPressHandler, role: 'dialog', 'aria-labelledby': titleId}} + overlayProps={{ + ...overlayProps, + onKeyPress: overlayKeyPressHandler, + role: 'dialog', + 'aria-labelledby': titleId, + 'aria-modal': true + }} focusTrapSettings={focusTrapSettings} focusZoneSettings={focusZoneSettings} > @@ -218,7 +224,7 @@ export function SelectPanel({ ? 'No matching items' : `${items.length} matching ${items.length === 1 ? 'item' : 'items'}`} - + {title} @@ -242,10 +248,11 @@ export function SelectPanel({ alignItems="center" justifyContent="flex-end" gridGap="8px" - padding="12px" + p={2} borderTopColor="border.default" borderTopWidth={1} borderTopStyle="solid" + as="footer" >