feat(ThemeProvider): add dark, light alias for ThemeProvider #2259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c07ffb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
colebemis
approved these changes
Aug 23, 2022
Contributor
colebemis
left a comment
colebemis
left a comment
There was a problem hiding this comment.
This will be convenient for product teams. Thanks, @joshblack!
Contributor
Maybe copy and paste these test cases and replace https://github.com/primer/react/blob/main/src/__tests__/ThemeProvider.test.tsx#L119-L137 |
Member
Author
|
@colebemis love it, done! |
joshblack
commented
Aug 24, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/919
Update
ThemeProvider'sColorModeto acceptdarkandlightas aliases fornightandday. Let me know if I missed any branches here that could be seeingdarkorlightascolorMode, was trying to following along in the source code but could easily have missed a path 👀Question for reviewers
What would be the best way to test this in
ThemeProvider.test.tsx? 👀