From 087620c319cd79e8092197a2115a8221db0a6d4d Mon Sep 17 00:00:00 2001 From: Josep Martins Date: Tue, 23 Aug 2022 16:18:00 +0200 Subject: [PATCH 1/7] Add new accessible frontmatter variable --- docs/content/ActionMenu.mdx | 1 + docs/content/Select.mdx | 1 + 2 files changed, 2 insertions(+) diff --git a/docs/content/ActionMenu.mdx b/docs/content/ActionMenu.mdx index 10d697cc845..a589c6a015a 100644 --- a/docs/content/ActionMenu.mdx +++ b/docs/content/ActionMenu.mdx @@ -2,6 +2,7 @@ componentId: action_menu title: ActionMenu status: Beta +accessible: true source: https://github.com/primer/react/tree/main/src/ActionMenu.tsx storybook: '/react/storybook?path=/story/composite-components-actionmenu' description: An ActionMenu is an ActionList-based component for creating a menu of actions that expands through a trigger button. diff --git a/docs/content/Select.mdx b/docs/content/Select.mdx index b90bad313a8..9d4866c5745 100644 --- a/docs/content/Select.mdx +++ b/docs/content/Select.mdx @@ -3,6 +3,7 @@ componentId: select title: Select description: Use a select input when a user needs to select one option from a long list status: Alpha +accessible: true source: https://github.com/primer/react/blob/main/src/Select.tsx storybook: '/react/storybook?path=/story/forms-form-controls-select--default' --- From 2188582e25cc114257bab00a66d95202ad246658 Mon Sep 17 00:00:00 2001 From: Josep Martins Date: Tue, 23 Aug 2022 16:25:54 +0200 Subject: [PATCH 2/7] Add calm-clouds-impress changeset --- .changeset/calm-clouds-impress.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/calm-clouds-impress.md diff --git a/.changeset/calm-clouds-impress.md b/.changeset/calm-clouds-impress.md new file mode 100644 index 00000000000..60c598bde5c --- /dev/null +++ b/.changeset/calm-clouds-impress.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Add new accessible frontmatter variable From 4d92a41209a17c3ced099750b90402058973be51 Mon Sep 17 00:00:00 2001 From: Josep Martins Date: Fri, 26 Aug 2022 15:55:48 +0200 Subject: [PATCH 3/7] Add Accessible column in Component status --- docs/src/component-statuses.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/docs/src/component-statuses.js b/docs/src/component-statuses.js index 6468b0de750..e5d854468af 100644 --- a/docs/src/component-statuses.js +++ b/docs/src/component-statuses.js @@ -1,5 +1,5 @@ import componentMetadata from '@primer/component-metadata' -import {Link} from '@primer/react' +import {Link, Label, Text} from '@primer/react' import StatusLabel from '@primer/gatsby-theme-doctocat/src/components/status-label' import Table from '@primer/gatsby-theme-doctocat/src/components/table' import {graphql, Link as GatsbyLink, useStaticQuery} from 'gatsby' @@ -16,6 +16,7 @@ export function ComponentStatuses() { title status description + accessible componentId } } @@ -37,13 +38,14 @@ export function ComponentStatuses() { Component Status + Accessibility Description {pages.map(page => { // eslint-disable-next-line prefer-const - let {title, status, description, componentId} = page.context.frontmatter + let {title, status, description, componentId, accessible} = page.context.frontmatter const component = componentMetadata.components[componentId] @@ -60,9 +62,12 @@ export function ComponentStatuses() { {title} - + + + {accessible ? : -} + {description} ) From 98885b054bb15c0f685ee81f630cd926bc0714b5 Mon Sep 17 00:00:00 2001 From: Josep Martins Date: Mon, 29 Aug 2022 10:09:00 +0200 Subject: [PATCH 4/7] Rename variable to a11yReviewed --- docs/content/ActionMenu.mdx | 2 +- docs/content/Select.mdx | 2 +- docs/src/component-statuses.js | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/docs/content/ActionMenu.mdx b/docs/content/ActionMenu.mdx index 67452a5a070..c8dbccbe3ac 100644 --- a/docs/content/ActionMenu.mdx +++ b/docs/content/ActionMenu.mdx @@ -2,7 +2,7 @@ componentId: action_menu title: ActionMenu status: Beta -accessible: true +a11yReviewed: true source: https://github.com/primer/react/tree/main/src/ActionMenu.tsx storybook: '/react/storybook?path=/story/composite-components-actionmenu' description: An ActionMenu is an ActionList-based component for creating a menu of actions that expands through a trigger button. diff --git a/docs/content/Select.mdx b/docs/content/Select.mdx index 9d4866c5745..a2ee1e296a2 100644 --- a/docs/content/Select.mdx +++ b/docs/content/Select.mdx @@ -3,7 +3,7 @@ componentId: select title: Select description: Use a select input when a user needs to select one option from a long list status: Alpha -accessible: true +a11yReviewed: true source: https://github.com/primer/react/blob/main/src/Select.tsx storybook: '/react/storybook?path=/story/forms-form-controls-select--default' --- diff --git a/docs/src/component-statuses.js b/docs/src/component-statuses.js index e5d854468af..1ce9b5cdd0d 100644 --- a/docs/src/component-statuses.js +++ b/docs/src/component-statuses.js @@ -16,7 +16,7 @@ export function ComponentStatuses() { title status description - accessible + a11yReviewed componentId } } @@ -45,7 +45,7 @@ export function ComponentStatuses() { {pages.map(page => { // eslint-disable-next-line prefer-const - let {title, status, description, componentId, accessible} = page.context.frontmatter + let {title, status, description, componentId, a11yReviewed} = page.context.frontmatter const component = componentMetadata.components[componentId] @@ -66,7 +66,7 @@ export function ComponentStatuses() { - {accessible ? : -} + {a11yReviewed ? : -} {description} From 6dfd2ccd8829a067249af4dfd979a4166e50a96f Mon Sep 17 00:00:00 2001 From: Josep Martins Date: Mon, 12 Sep 2022 16:47:08 +0200 Subject: [PATCH 5/7] Adjust Label variant --- docs/src/component-statuses.js | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/docs/src/component-statuses.js b/docs/src/component-statuses.js index 1ce9b5cdd0d..c3aa9da52b4 100644 --- a/docs/src/component-statuses.js +++ b/docs/src/component-statuses.js @@ -37,8 +37,8 @@ export function ComponentStatuses() { Component - Status - Accessibility + Status + Accessibility Description @@ -62,11 +62,15 @@ export function ComponentStatuses() { {title} - + - - {a11yReviewed ? : -} + + {a11yReviewed ? ( + + ) : ( + Not reviewed + )} {description} From 57680fafd20f05fd13fc8354cd4c5e57af027212 Mon Sep 17 00:00:00 2001 From: Josep Martins Date: Wed, 21 Sep 2022 14:11:47 +0200 Subject: [PATCH 6/7] Pending review --- docs/src/component-statuses.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/component-statuses.js b/docs/src/component-statuses.js index c3aa9da52b4..a717a3e72d3 100644 --- a/docs/src/component-statuses.js +++ b/docs/src/component-statuses.js @@ -69,7 +69,7 @@ export function ComponentStatuses() { {a11yReviewed ? ( ) : ( - Not reviewed + Pending review )} {description} From 67c378b0557add5d3f60eecaf718f64e81e1b1e4 Mon Sep 17 00:00:00 2001 From: Josep Martins Date: Tue, 27 Sep 2022 17:34:19 +0200 Subject: [PATCH 7/7] Update component-statuses.js --- docs/src/component-statuses.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/src/component-statuses.js b/docs/src/component-statuses.js index a717a3e72d3..d367f7b8040 100644 --- a/docs/src/component-statuses.js +++ b/docs/src/component-statuses.js @@ -69,7 +69,7 @@ export function ComponentStatuses() { {a11yReviewed ? ( ) : ( - Pending review + Review pending )} {description}