From 2c3176b4a2caaeb7d1aa92a1d351f19cb03a6130 Mon Sep 17 00:00:00 2001 From: Erik Hughes Date: Fri, 17 Jun 2022 14:01:37 -0400 Subject: [PATCH 1/3] fix: allow autocomplete input value to be falsely --- src/Autocomplete/AutocompleteInput.tsx | 4 +--- src/__tests__/Autocomplete.test.tsx | 6 ++++++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/Autocomplete/AutocompleteInput.tsx b/src/Autocomplete/AutocompleteInput.tsx index db31ba51ee2..20a5f0b7404 100644 --- a/src/Autocomplete/AutocompleteInput.tsx +++ b/src/Autocomplete/AutocompleteInput.tsx @@ -146,9 +146,7 @@ const AutocompleteInput = React.forwardRef( }, [autocompleteSuggestion, inputValue, inputRef, isMenuDirectlyActivated]) useEffect(() => { - if (value) { - setInputValue(value.toString()) - } + setInputValue(typeof value !== 'undefined' ? value.toString() : '') }, [value, setInputValue]) return ( diff --git a/src/__tests__/Autocomplete.test.tsx b/src/__tests__/Autocomplete.test.tsx index 02007bb16c6..5fbf8ae2417 100644 --- a/src/__tests__/Autocomplete.test.tsx +++ b/src/__tests__/Autocomplete.test.tsx @@ -321,6 +321,12 @@ describe('Autocomplete', () => { inputNode && userEvent.type(inputNode, '{esc}') expect(inputNode?.getAttribute('aria-expanded')).not.toBe('true') }) + + it('allows the value to be 0', () => { + const {getByDisplayValue} = HTMLRender() + + expect(getByDisplayValue('0')).toBeDefined() + }) }) describe('Autocomplete.Menu', () => { From 751901dd37eb123823da7361fffef6f534077958 Mon Sep 17 00:00:00 2001 From: Erik Hughes Date: Fri, 17 Jun 2022 14:14:01 -0400 Subject: [PATCH 2/3] chore: added changeset --- .changeset/cold-bottles-attend.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/cold-bottles-attend.md diff --git a/.changeset/cold-bottles-attend.md b/.changeset/cold-bottles-attend.md new file mode 100644 index 00000000000..4447ed55e49 --- /dev/null +++ b/.changeset/cold-bottles-attend.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Allow "falsely/empty" Autocomplete.Input values From 6b633f0ac8e5501096324356a5818f34822f4a57 Mon Sep 17 00:00:00 2001 From: Mike Perrotti Date: Mon, 20 Jun 2022 23:27:45 -0400 Subject: [PATCH 3/3] fixes linting error --- src/__tests__/Autocomplete.test.tsx | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/__tests__/Autocomplete.test.tsx b/src/__tests__/Autocomplete.test.tsx index 5fbf8ae2417..487c936d591 100644 --- a/src/__tests__/Autocomplete.test.tsx +++ b/src/__tests__/Autocomplete.test.tsx @@ -323,7 +323,9 @@ describe('Autocomplete', () => { }) it('allows the value to be 0', () => { - const {getByDisplayValue} = HTMLRender() + const {getByDisplayValue} = HTMLRender( + + ) expect(getByDisplayValue('0')).toBeDefined() })