From 14e31c68c6124bc1759e35a1e89b64d2ba7d516f Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Thu, 19 May 2022 17:21:52 +0200 Subject: [PATCH 1/6] Uncomment deploy guard --- .github/workflows/deploy_production.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/deploy_production.yml b/.github/workflows/deploy_production.yml index f470171026e..9616bb3b612 100644 --- a/.github/workflows/deploy_production.yml +++ b/.github/workflows/deploy_production.yml @@ -35,7 +35,7 @@ jobs: deploy: name: Production needs: [guard] - #if: ${{ needs.guard.outputs.should_deploy == true }} + if: ${{ needs.guard.outputs.should_deploy == true }} uses: primer/.github/.github/workflows/deploy.yml@main with: node_version: 16 From 32dfdad1317c1ebbb573eae4bba48f757590ab43 Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Thu, 19 May 2022 17:23:51 +0200 Subject: [PATCH 2/6] temp: change branch for testing --- .github/workflows/deploy_production.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/deploy_production.yml b/.github/workflows/deploy_production.yml index 9616bb3b612..ca753662741 100644 --- a/.github/workflows/deploy_production.yml +++ b/.github/workflows/deploy_production.yml @@ -3,7 +3,7 @@ name: Deploy on: push: branches: - - main + - siddharthkp/uncomment-deploy-guard permissions: contents: read From 6c6855b4f8a5115e0aa3862fe729e760b7d1edca Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Thu, 19 May 2022 17:30:01 +0200 Subject: [PATCH 3/6] change branch back to main --- .github/workflows/deploy_production.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/deploy_production.yml b/.github/workflows/deploy_production.yml index ca753662741..9616bb3b612 100644 --- a/.github/workflows/deploy_production.yml +++ b/.github/workflows/deploy_production.yml @@ -3,7 +3,7 @@ name: Deploy on: push: branches: - - siddharthkp/uncomment-deploy-guard + - main permissions: contents: read From 99e751dad1b17f5c028fb29f0b311639c362e078 Mon Sep 17 00:00:00 2001 From: Siddharth Kshetrapal Date: Fri, 20 May 2022 16:06:30 +0200 Subject: [PATCH 4/6] temp: check if it works with no changesets --- .changeset/breezy-cooks-destroy.md | 5 ----- .changeset/cold-pillows-protect.md | 5 ----- .changeset/happy-brooms-swim.md | 5 ----- .changeset/iconbutton-default-tooltip.md | 5 ----- .changeset/improved-tooltip.md | 6 ------ .changeset/silent-falcons-exist.md | 5 ----- .changeset/six-mirrors-call.md | 5 ----- .changeset/strong-nails-sip.md | 5 ----- .changeset/tame-swans-rush.md | 7 ------- .changeset/wicked-boats-allow.md | 5 ----- .github/workflows/deploy_production.yml | 2 +- 11 files changed, 1 insertion(+), 54 deletions(-) delete mode 100644 .changeset/breezy-cooks-destroy.md delete mode 100644 .changeset/cold-pillows-protect.md delete mode 100644 .changeset/happy-brooms-swim.md delete mode 100644 .changeset/iconbutton-default-tooltip.md delete mode 100644 .changeset/improved-tooltip.md delete mode 100644 .changeset/silent-falcons-exist.md delete mode 100644 .changeset/six-mirrors-call.md delete mode 100644 .changeset/strong-nails-sip.md delete mode 100644 .changeset/tame-swans-rush.md delete mode 100644 .changeset/wicked-boats-allow.md diff --git a/.changeset/breezy-cooks-destroy.md b/.changeset/breezy-cooks-destroy.md deleted file mode 100644 index ef9811a393b..00000000000 --- a/.changeset/breezy-cooks-destroy.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@primer/react": patch ---- - -Add draft of `NavList` component diff --git a/.changeset/cold-pillows-protect.md b/.changeset/cold-pillows-protect.md deleted file mode 100644 index 9e4f0e8b250..00000000000 --- a/.changeset/cold-pillows-protect.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@primer/react': patch ---- - -Fixes accessibility bugs in the Select component. diff --git a/.changeset/happy-brooms-swim.md b/.changeset/happy-brooms-swim.md deleted file mode 100644 index 22071270e62..00000000000 --- a/.changeset/happy-brooms-swim.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@primer/react": patch ---- - -Adds support for the `sx` prop on the draft implementation of `NavList` and all its subcomponents (e.g., `NavList.Item`) diff --git a/.changeset/iconbutton-default-tooltip.md b/.changeset/iconbutton-default-tooltip.md deleted file mode 100644 index 7fb2b407016..00000000000 --- a/.changeset/iconbutton-default-tooltip.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@primer/react': minor ---- - -[IconButton](https://primer.style/react/IconButton) now has a tooltip by default, it can be [customised by wrapping in a Tooltip](https://primer.style/react/IconButton#customize-description--tooltip-text) ([#2006](https://github.com/primer/react/pull/2006)) diff --git a/.changeset/improved-tooltip.md b/.changeset/improved-tooltip.md deleted file mode 100644 index acaea20e976..00000000000 --- a/.changeset/improved-tooltip.md +++ /dev/null @@ -1,6 +0,0 @@ ---- -'@primer/react': patch ---- - -Accessibility and position fixes (backward compatible) for Tooltip ([#2006](https://github.com/primer/react/pull/2006)) - diff --git a/.changeset/silent-falcons-exist.md b/.changeset/silent-falcons-exist.md deleted file mode 100644 index aad227a4aa9..00000000000 --- a/.changeset/silent-falcons-exist.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@primer/react': patch ---- - -Finishes updating components with the global focus styles defined in Primer CSS ([this PR](https://github.com/primer/css/pull/1744)) diff --git a/.changeset/six-mirrors-call.md b/.changeset/six-mirrors-call.md deleted file mode 100644 index 27fe11af10b..00000000000 --- a/.changeset/six-mirrors-call.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@primer/react": patch ---- - -Fixes layout bug with ButtonGroup by changing the `display` property from `inline-block` to `inline-flex` diff --git a/.changeset/strong-nails-sip.md b/.changeset/strong-nails-sip.md deleted file mode 100644 index c6a801bd390..00000000000 --- a/.changeset/strong-nails-sip.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@primer/react": patch ---- - -Add support for sub-items in draft implementation of NavList diff --git a/.changeset/tame-swans-rush.md b/.changeset/tame-swans-rush.md deleted file mode 100644 index 95692860c57..00000000000 --- a/.changeset/tame-swans-rush.md +++ /dev/null @@ -1,7 +0,0 @@ ---- -'@primer/react': patch ---- - -- adds [`color-scheme`](https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme) style to inputs so they get the correct user-agent dark/light styles -- crops ToggleSwitch knob's shadow inside the toggle switch boundaries -- changes FormControl styles to prevent `