Skip to content

Uncomment deploy guard #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Uncomment deploy guard #2085

wants to merge 7 commits into from

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented May 19, 2022 •
edited
Loading

Fixes #2070

We already had a deployment guard based on changesets, but it was commented out 😅

Testing by changing the branch name in workflow

image

  • TODO: change the branch back to main

Is there a way to mention a reason why the job was skipped?

@siddharthkp siddharthkp requested a review from a team May 19, 2022 15:22
@changeset-bot
Copy link

changeset-bot bot commented May 19, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4bab670

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp requested a review from colebemis May 19, 2022 15:22
@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label May 19, 2022
@siddharthkp siddharthkp self-assigned this May 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 19, 2022 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 65.93 KB (0%)
dist/browser.umd.js 66.24 KB (0%)

@siddharthkp siddharthkp temporarily deployed to github-pages May 20, 2022 14:06 Inactive
@siddharthkp
Copy link
Member Author

siddharthkp commented May 23, 2022

Fixed in #2091 instead

@joshblack joshblack deleted the siddharthkp/uncomment-deploy-guard branch January 19, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colebemis colebemis Awaiting requested review from colebemis

Assignees

@siddharthkp siddharthkp

Labels

react skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Docs use unreleased release candidate instead of published version

2 participants

@siddharthkp