Skip to content

Conversation

@siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Mar 30, 2022

We should always run visual testing on main so that we have an updated baseline to compare changes in pull requests.

Right now, that means you would have to manually approve the visual-regression action on main every time your merge 👎. It makes sense to not require an approval for main

environment: ${{ github.ref == 'refs/heads/main' && 'Preview' || 'needs-approval' }}

After this PR is merged, we can delete the previous protected environment: visual-testing

@siddharthkp siddharthkp requested review from a team and mperrotti March 30, 2022 09:48
@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2022

⚠️ No Changeset found

Latest commit: 9c64018

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkp siddharthkp self-assigned this Mar 30, 2022
@siddharthkp siddharthkp requested review from rezrah and removed request for mperrotti March 30, 2022 09:48
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 65.72 KB (0%)
dist/browser.umd.js 66.11 KB (0%)

@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Mar 30, 2022
@siddharthkp siddharthkp changed the title Use pre-approved environment for main Visual regression testing: Remove manual approval for main Mar 30, 2022
@siddharthkp siddharthkp requested a review from mperrotti March 30, 2022 09:56
@siddharthkp siddharthkp merged commit 8c32020 into main Mar 30, 2022
@siddharthkp siddharthkp deleted the siddharth/auto-approve-visual-testing-on-main branch March 30, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

react skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants