From d39faf6fa12ce4dbf9b9a5a9f399cf142369da2e Mon Sep 17 00:00:00 2001 From: Pavithra Kodmad Date: Wed, 16 Mar 2022 20:28:13 +1100 Subject: [PATCH 1/3] Add overlay props to Autocomplete.Overlay --- src/Autocomplete/AutocompleteOverlay.tsx | 11 +++++++++-- src/stories/Autocomplete.stories.tsx | 7 +------ 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/src/Autocomplete/AutocompleteOverlay.tsx b/src/Autocomplete/AutocompleteOverlay.tsx index fb318261d10..f1150b9256a 100644 --- a/src/Autocomplete/AutocompleteOverlay.tsx +++ b/src/Autocomplete/AutocompleteOverlay.tsx @@ -15,13 +15,20 @@ type AutocompleteOverlayInternalProps = { */ overlayProps?: Partial children?: React.ReactNode -} & Pick // TODO: consider making 'aria-labelledby' required +} & Partial & + Pick // TODO: consider making 'aria-labelledby' required -function AutocompleteOverlay({menuAnchorRef, overlayProps, children}: AutocompleteOverlayInternalProps) { +function AutocompleteOverlay({ + menuAnchorRef, + overlayProps: oldOverlayProps, + children, + ...newOverlayProps +}: AutocompleteOverlayInternalProps) { const autocompleteContext = useContext(AutocompleteContext) if (autocompleteContext === null) { throw new Error('AutocompleteContext returned null values') } + const overlayProps = {...oldOverlayProps, ...newOverlayProps} const {inputRef, scrollContainerRef, selectedItemLength, setShowMenu, showMenu = false} = autocompleteContext const {floatingElementRef, position} = useAnchoredPosition( { diff --git a/src/stories/Autocomplete.stories.tsx b/src/stories/Autocomplete.stories.tsx index 0968cd9691c..62555212894 100644 --- a/src/stories/Autocomplete.stories.tsx +++ b/src/stories/Autocomplete.stories.tsx @@ -558,12 +558,7 @@ export const WithCustomOverlayProps = () => { - + From 85845579cc816e553f41916736f7655413657046 Mon Sep 17 00:00:00 2001 From: Pavithra Kodmad Date: Wed, 16 Mar 2022 20:34:10 +1100 Subject: [PATCH 2/3] Improve documentation --- docs/content/Autocomplete.mdx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/content/Autocomplete.mdx b/docs/content/Autocomplete.mdx index 1a0454b74da..79837015178 100644 --- a/docs/content/Autocomplete.mdx +++ b/docs/content/Autocomplete.mdx @@ -23,7 +23,8 @@ The `Autocomplete.Input` should not be rendered without a `