From 1617633c9997132cf71d891502b7636f0e344dd3 Mon Sep 17 00:00:00 2001
From: Cole Bemis <colebemis@github.com>
Date: Mon, 14 Mar 2022 15:03:41 -0700
Subject: [PATCH 01/13] Add type check npm script

---
 package.json        | 1 +
 tsconfig.build.json | 1 +
 tsconfig.json       | 1 -
 3 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/package.json b/package.json
index a01da6a3276..6e9f3d5e1a2 100644
--- a/package.json
+++ b/package.json
@@ -44,6 +44,7 @@
     "lint:fix": "npm run lint -- --fix",
     "test": "jest",
     "test:update": "npm run test -- --updateSnapshot",
+    "test:type-check": "tsc --noEmit",
     "release": "npm run build && changeset publish",
     "size": "size-limit",
     "prepare": "husky install"
diff --git a/tsconfig.build.json b/tsconfig.build.json
index 561345472aa..953b62a979e 100644
--- a/tsconfig.build.json
+++ b/tsconfig.build.json
@@ -1,5 +1,6 @@
 {
   "extends": "./tsconfig.json",
+  "emitDeclarationOnly": true,
   // NOTE: We exclude Storybook stories and test utilities which import
   // Storybook and its dependencies, because:
   //   a) we don't want Storybook types in our build output, and
diff --git a/tsconfig.json b/tsconfig.json
index f5e13b8ceb5..7bb26edce02 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -7,7 +7,6 @@
     "jsx": "preserve",
     "declaration": true,
     "outDir": "./lib",
-    "emitDeclarationOnly": true,
     "strict": true,
     "moduleResolution": "node",
     "rootDirs": ["src"],

From 5353d0cb4d5c9dad5bf362469c494fa2f74adb6a Mon Sep 17 00:00:00 2001
From: Cole Bemis <colebemis@github.com>
Date: Mon, 14 Mar 2022 15:05:17 -0700
Subject: [PATCH 02/13] Add type checking to CI

---
 .github/workflows/ci.yml | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 4c4f1d4cc64..ad5fc2c5e0f 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -29,3 +29,6 @@ jobs:
 
       - name: Test
         run: npm run test
+
+      - name: Type check
+        run: npm run test:type-check

From 569c4327e616cdf3dfc782756ebfe2d09addbb1f Mon Sep 17 00:00:00 2001
From: Cole Bemis <colebemis@github.com>
Date: Mon, 14 Mar 2022 17:27:49 -0700
Subject: [PATCH 03/13] Make value prop of Checkbox optional

---
 src/Checkbox.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/Checkbox.tsx b/src/Checkbox.tsx
index d7aeb16090a..bbad54491ca 100644
--- a/src/Checkbox.tsx
+++ b/src/Checkbox.tsx
@@ -30,7 +30,7 @@ export type CheckboxProps = {
    * A unique value that is never shown to the user.
    * Used during form submission and to identify which checkbox inputs are selected
    */
-  value: string
+  value?: string
 } & Exclude<InputHTMLAttributes<HTMLInputElement>, 'value'> &
   SxProp
 

From ec94d9836bc915cf4fa8981f01e857bf82ed973b Mon Sep 17 00:00:00 2001
From: Cole Bemis <colebemis@github.com>
Date: Mon, 14 Mar 2022 17:29:42 -0700
Subject: [PATCH 04/13] Export Select props type

---
 src/Select.tsx | 6 +++---
 src/index.ts   | 1 +
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/Select.tsx b/src/Select.tsx
index ac9cfeeaf02..25708efa576 100644
--- a/src/Select.tsx
+++ b/src/Select.tsx
@@ -3,8 +3,8 @@ import styled from 'styled-components'
 import {get} from './constants'
 import TextInputWrapper, {StyledWrapperProps} from './_TextInputWrapper'
 
-type SelectProps = Omit<
-  Omit<React.HTMLProps<HTMLSelectElement>, 'size'> & Omit<StyledWrapperProps, 'variant'>,
+export type SelectProps = Omit<
+  Omit<React.ComponentPropsWithoutRef<'select'>, 'size'> & Omit<StyledWrapperProps, 'variant'>,
   'multiple' | 'hasLeadingVisual' | 'hasTrailingVisual' | 'as'
 >
 
@@ -42,7 +42,7 @@ const ArrowIndicator = styled(ArrowIndicatorSVG)`
 `
 
 const Select = React.forwardRef<HTMLSelectElement, SelectProps>(
-  ({children, disabled, placeholder, size, required, validationStatus, ref: _propsRef, ...rest}: SelectProps, ref) => (
+  ({children, disabled, placeholder, size, required, validationStatus, ...rest}: SelectProps, ref) => (
     <TextInputWrapper
       sx={{
         position: 'relative'
diff --git a/src/index.ts b/src/index.ts
index c1aa54499cc..43a8481f2d6 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -111,6 +111,7 @@ export {default as ProgressBar} from './ProgressBar'
 export type {ProgressBarProps} from './ProgressBar'
 export {default as RadioGroup} from './RadioGroup'
 export {default as Select} from './Select'
+export type {SelectProps} from './Select'
 export {SelectPanel} from './SelectPanel'
 export type {SelectPanelProps} from './SelectPanel'
 export {default as SideNav} from './SideNav'

From 1808b8ac4f940a86ef9a4a30fbf1d6ab7456c797 Mon Sep 17 00:00:00 2001
From: Cole Bemis <colebemis@github.com>
Date: Mon, 14 Mar 2022 17:30:01 -0700
Subject: [PATCH 05/13] Update LabelGroup test

---
 src/__tests__/LabelGroup.test.tsx | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/__tests__/LabelGroup.test.tsx b/src/__tests__/LabelGroup.test.tsx
index df1636dfee1..3c666e86096 100644
--- a/src/__tests__/LabelGroup.test.tsx
+++ b/src/__tests__/LabelGroup.test.tsx
@@ -10,7 +10,6 @@ const comp = (
   <LabelGroup>
     <Label>Default label</Label>
     <Label>Darker gray label</Label>
-    <Label outline>Default outline label</Label>
   </LabelGroup>
 )
 

From cd844e851b0d7186e435cdcf698af8cff57c3048 Mon Sep 17 00:00:00 2001
From: Cole Bemis <colebemis@github.com>
Date: Mon, 14 Mar 2022 17:30:13 -0700
Subject: [PATCH 06/13] Update import in deprecated Label type test

---
 src/__tests__/deprecated/Label.types.test.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/__tests__/deprecated/Label.types.test.tsx b/src/__tests__/deprecated/Label.types.test.tsx
index dcfa2638521..a88a34a76ef 100644
--- a/src/__tests__/deprecated/Label.types.test.tsx
+++ b/src/__tests__/deprecated/Label.types.test.tsx
@@ -1,5 +1,5 @@
 import React from 'react'
-import Label from '../deprecated/Label'
+import Label from '../../deprecated/Label'
 
 export function shouldAcceptCallWithNoProps() {
   return <Label />

From 77ada8587afe7a946b212f02b072296d01f28642 Mon Sep 17 00:00:00 2001
From: Cole Bemis <colebemis@github.com>
Date: Mon, 14 Mar 2022 17:30:46 -0700
Subject: [PATCH 07/13] Update Button import in PageLayout story

---
 src/PageLayout/PageLayout.stories.tsx | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/PageLayout/PageLayout.stories.tsx b/src/PageLayout/PageLayout.stories.tsx
index 50e66080990..93d41a0a459 100644
--- a/src/PageLayout/PageLayout.stories.tsx
+++ b/src/PageLayout/PageLayout.stories.tsx
@@ -1,7 +1,6 @@
 import {Meta, Story} from '@storybook/react'
 import React from 'react'
-import {Box, BranchName, Heading, Link, SideNav, StateLabel, TabNav, Text} from '..'
-import {Button} from '../drafts'
+import {Box, BranchName, Heading, Link, SideNav, StateLabel, TabNav, Text, Button} from '..'
 import {Placeholder} from '../Placeholder'
 import {PageLayout} from './PageLayout'
 

From 79b9cb7e62848e329b27b231224198fe17a145ea Mon Sep 17 00:00:00 2001
From: Cole Bemis <colebemis@github.com>
Date: Mon, 14 Mar 2022 17:31:18 -0700
Subject: [PATCH 08/13] Update import in anchored position story

---
 src/stories/useAnchoredPosition.stories.tsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/stories/useAnchoredPosition.stories.tsx b/src/stories/useAnchoredPosition.stories.tsx
index ff68b1b28dc..ed9eb61ac81 100644
--- a/src/stories/useAnchoredPosition.stories.tsx
+++ b/src/stories/useAnchoredPosition.stories.tsx
@@ -7,7 +7,7 @@ import styled from 'styled-components'
 import {get} from '../constants'
 import type {AnchorSide} from '@primer/behaviors'
 import Portal, {registerPortalRoot} from '../Portal'
-import Button from '../Button'
+import {Button} from '../Button'
 
 export default {
   title: 'Hooks/useAnchoredPosition',

From 0ca117c513469e6b080b1046de073002f84c4360 Mon Sep 17 00:00:00 2001
From: Cole Bemis <colebemis@github.com>
Date: Mon, 14 Mar 2022 17:31:49 -0700
Subject: [PATCH 09/13] Remove htmlFor prop from FormControl.Label in
 ActionMenu story

---
 src/stories/ActionMenu/fixtures.stories.tsx | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/stories/ActionMenu/fixtures.stories.tsx b/src/stories/ActionMenu/fixtures.stories.tsx
index ab6876e9313..46d960a9ad3 100644
--- a/src/stories/ActionMenu/fixtures.stories.tsx
+++ b/src/stories/ActionMenu/fixtures.stories.tsx
@@ -340,11 +340,7 @@ const LayoutToggleItem = ({
         }
       }}
     >
-      <FormControl.Label
-        htmlFor="layout-selector"
-        sx={{fontWeight: 'normal', cursor: 'pointer', px: 3, py: 2, mb: 0}}
-        {...props}
-      >
+      <FormControl.Label sx={{fontWeight: 'normal', cursor: 'pointer', px: 3, py: 2, mb: 0}} {...props}>
         <Box sx={{textAlign: 'center', flexDirection: 'column', m: 'auto', alignItems: 'center', display: 'flex'}}>
           <Icon size="medium" />
           <Text sx={{color: selected ? 'fg.default' : 'fg.muted', fontSize: 0}}>{children}</Text>

From 1e48324ec37adf38cf35b80f4fd1fe573abc23c4 Mon Sep 17 00:00:00 2001
From: Cole Bemis <colebemis@github.com>
Date: Mon, 14 Mar 2022 17:32:09 -0700
Subject: [PATCH 10/13] Update Label in deprecated ActionList story

---
 src/stories/deprecated/ActionList.stories.tsx | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/src/stories/deprecated/ActionList.stories.tsx b/src/stories/deprecated/ActionList.stories.tsx
index 615511ac43d..0659ae39d9c 100644
--- a/src/stories/deprecated/ActionList.stories.tsx
+++ b/src/stories/deprecated/ActionList.stories.tsx
@@ -311,11 +311,7 @@ export function CustomItemChildren(): JSX.Element {
           items={[
             {
               leadingVisual: ArrowRightIcon,
-              children: (
-                <Label outline borderColor="success.emphasis">
-                  Choose this one
-                </Label>
-              ),
+              children: <Label>Choose this one</Label>,
               trailingIcon: ArrowLeftIcon
             }
           ]}

From 92f8e3a948f53fcae9bf0459a068351b98903af9 Mon Sep 17 00:00:00 2001
From: Cole Bemis <colebemis@github.com>
Date: Mon, 14 Mar 2022 17:42:43 -0700
Subject: [PATCH 11/13] Comment out LinkButton stories

---
 src/Button/Button2.stories.tsx | 104 ++++++++++++++++-----------------
 1 file changed, 52 insertions(+), 52 deletions(-)

diff --git a/src/Button/Button2.stories.tsx b/src/Button/Button2.stories.tsx
index 033030ddb7d..2df7749e413 100644
--- a/src/Button/Button2.stories.tsx
+++ b/src/Button/Button2.stories.tsx
@@ -1,8 +1,8 @@
-import React, {useState, forwardRef} from 'react'
-import {Button, ButtonProps, IconButton, LinkButton} from '.'
-import {BaseStyles, ThemeProvider} from '..'
+import {EyeClosedIcon, EyeIcon, SearchIcon, TriangleDownIcon, XIcon} from '@primer/octicons-react'
 import {Meta} from '@storybook/react'
-import {XIcon, SearchIcon, EyeIcon, EyeClosedIcon, TriangleDownIcon, TriangleRightIcon} from '@primer/octicons-react'
+import React, {useState} from 'react'
+import {Button, ButtonProps, IconButton} from '.'
+import {BaseStyles, ThemeProvider} from '..'
 import Box from '../Box'
 
 export default {
@@ -186,52 +186,52 @@ export const disabledButton = ({...args}: ButtonProps) => {
   )
 }
 
-type ReactRouterLikeLinkProps = {to: string; children: React.ReactNode}
-const ReactRouterLikeLink = forwardRef<HTMLAnchorElement, ReactRouterLikeLinkProps>(
-  ({to, ...props}: {to: string; children: React.ReactNode}, ref) => {
-    // eslint-disable-next-line jsx-a11y/anchor-has-content
-    return <a ref={ref} href={to} {...props} />
-  }
-)
+// type ReactRouterLikeLinkProps = {to: string; children: React.ReactNode}
+// const ReactRouterLikeLink = forwardRef<HTMLAnchorElement, ReactRouterLikeLinkProps>(
+//   ({to, ...props}: {to: string; children: React.ReactNode}, ref) => {
+//     // eslint-disable-next-line jsx-a11y/anchor-has-content
+//     return <a ref={ref} href={to} {...props} />
+//   }
+// )
 
-export const linkButton = ({...args}: ButtonProps) => {
-  return (
-    <>
-      <Box mb={2} display="flex">
-        <LinkButton href="https://primer.style/" {...args}>
-          Link to Primer
-        </LinkButton>
-      </Box>
-      <Box mb={2} display="flex">
-        <LinkButton href="https://primer.style/" variant="danger" {...args}>
-          Link to Primer
-        </LinkButton>
-      </Box>
-      <Box mb={2} display="flex">
-        <LinkButton href="https://primer.style/" variant="primary" {...args}>
-          Link to Primer
-        </LinkButton>
-      </Box>
-      <Box mb={2} display="flex">
-        <LinkButton href="https://primer.style/" variant="outline" {...args}>
-          Link to Primer
-        </LinkButton>
-      </Box>
-      <Box mb={2} display="flex">
-        <LinkButton href="https://primer.style/" variant="invisible" {...args}>
-          Link to Primer
-        </LinkButton>
-      </Box>
-      <Box mb={2} display="flex">
-        <LinkButton href="https://primer.style/" variant="primary" trailingIcon={TriangleRightIcon} {...args}>
-          Link to Primer
-        </LinkButton>
-      </Box>
-      <Box mb={2} display="flex">
-        <LinkButton to="/dummy" as={ReactRouterLikeLink} variant="primary" trailingIcon={TriangleRightIcon} {...args}>
-          Link to Primer
-        </LinkButton>
-      </Box>
-    </>
-  )
-}
+// export const linkButton = ({...args}: ButtonProps) => {
+//   return (
+//     <>
+//       <Box mb={2} display="flex">
+//         <LinkButton href="https://primer.style/" {...args}>
+//           Link to Primer
+//         </LinkButton>
+//       </Box>
+//       <Box mb={2} display="flex">
+//         <LinkButton href="https://primer.style/" variant="danger" {...args}>
+//           Link to Primer
+//         </LinkButton>
+//       </Box>
+//       <Box mb={2} display="flex">
+//         <LinkButton href="https://primer.style/" variant="primary" {...args}>
+//           Link to Primer
+//         </LinkButton>
+//       </Box>
+//       <Box mb={2} display="flex">
+//         <LinkButton href="https://primer.style/" variant="outline" {...args}>
+//           Link to Primer
+//         </LinkButton>
+//       </Box>
+//       <Box mb={2} display="flex">
+//         <LinkButton href="https://primer.style/" variant="invisible" {...args}>
+//           Link to Primer
+//         </LinkButton>
+//       </Box>
+//       <Box mb={2} display="flex">
+//         <LinkButton href="https://primer.style/" variant="primary" trailingIcon={TriangleRightIcon} {...args}>
+//           Link to Primer
+//         </LinkButton>
+//       </Box>
+//       <Box mb={2} display="flex">
+//         <LinkButton to="/dummy" as={ReactRouterLikeLink} variant="primary" trailingIcon={TriangleRightIcon} {...args}>
+//           Link to Primer
+//         </LinkButton>
+//       </Box>
+//     </>
+//   )
+// }

From 428d8955f254f89935da95c2ade3e5ce80f6ca0b Mon Sep 17 00:00:00 2001
From: Cole Bemis <colebemis@github.com>
Date: Mon, 14 Mar 2022 17:52:53 -0700
Subject: [PATCH 12/13] Fix tsconfig.build.json

---
 tsconfig.build.json | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tsconfig.build.json b/tsconfig.build.json
index 953b62a979e..e90dbfc4260 100644
--- a/tsconfig.build.json
+++ b/tsconfig.build.json
@@ -1,6 +1,8 @@
 {
   "extends": "./tsconfig.json",
-  "emitDeclarationOnly": true,
+  "compilerOptions": {
+    "emitDeclarationOnly": true
+  },
   // NOTE: We exclude Storybook stories and test utilities which import
   // Storybook and its dependencies, because:
   //   a) we don't want Storybook types in our build output, and

From 333e0585497ec293caf6c35b79f6da0cf54c7fa6 Mon Sep 17 00:00:00 2001
From: Cole Bemis <colebemis@github.com>
Date: Tue, 15 Mar 2022 08:49:27 -0700
Subject: [PATCH 13/13] Create funny-ears-add.md

---
 .changeset/funny-ears-add.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/funny-ears-add.md

diff --git a/.changeset/funny-ears-add.md b/.changeset/funny-ears-add.md
new file mode 100644
index 00000000000..314f71b9e02
--- /dev/null
+++ b/.changeset/funny-ears-add.md
@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+Checkbox: `value` prop is now optional