From 9da12d1ddad481afc2b2381405476ab0c2982bf4 Mon Sep 17 00:00:00 2001 From: Cole Bemis Date: Tue, 22 Feb 2022 15:38:28 -0800 Subject: [PATCH 1/5] Export PageLayout from main bundle --- src/drafts/index.ts | 1 - src/index.ts | 8 ++++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/drafts/index.ts b/src/drafts/index.ts index 291e56dafbb..efa9ff196c5 100644 --- a/src/drafts/index.ts +++ b/src/drafts/index.ts @@ -11,4 +11,3 @@ export * from '../Button2' export * from '../ActionMenu2' export * from '../DropdownMenu2' export * from '../Label2' -export * from '../PageLayout' diff --git a/src/index.ts b/src/index.ts index 6a5c26f0c47..1052d93fa5b 100644 --- a/src/index.ts +++ b/src/index.ts @@ -16,6 +16,14 @@ export {default as Grid} from './Grid' export type {GridProps} from './Grid' export {default as Position, Absolute, Fixed, Relative, Sticky} from './Position' export type {PositionProps, AbsoluteProps, FixedProps, RelativeProps, StickyProps} from './Position' +export {PageLayout} from './PageLayout' +export type { + PageLayoutProps, + PageLayoutHeaderProps, + PageLayoutContentProps, + PageLayoutPaneProps, + PageLayoutFooterProps +} from './PageLayout' // Hooks export {default as useDetails} from './hooks/useDetails' From d9794ab84245bb739e730501bf94ba406b747147 Mon Sep 17 00:00:00 2001 From: Cole Bemis Date: Tue, 22 Feb 2022 15:43:07 -0800 Subject: [PATCH 2/5] Create odd-apes-guess.md --- .changeset/odd-apes-guess.md | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 .changeset/odd-apes-guess.md diff --git a/.changeset/odd-apes-guess.md b/.changeset/odd-apes-guess.md new file mode 100644 index 00000000000..64e10ea3b85 --- /dev/null +++ b/.changeset/odd-apes-guess.md @@ -0,0 +1,10 @@ +--- +"@primer/react": major +--- + +`PageLayout` has been moved from the `drafts` bundle to the main bundle. To upgrade, rewrite your imports accordingly: + +```diff +- import {PageLayout} from '@primer/react/drafts' ++ import {PageLayout} from '@primer/react' +``` From 6cbd9bc31d726034ee0dd76c2067320a6ca46d87 Mon Sep 17 00:00:00 2001 From: Cole Bemis Date: Wed, 23 Feb 2022 15:57:17 +0000 Subject: [PATCH 3/5] Add PageLayout to sidenav --- docs/src/@primer/gatsby-theme-doctocat/nav.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/src/@primer/gatsby-theme-doctocat/nav.yml b/docs/src/@primer/gatsby-theme-doctocat/nav.yml index 9584bf38cf0..0a313c91e00 100644 --- a/docs/src/@primer/gatsby-theme-doctocat/nav.yml +++ b/docs/src/@primer/gatsby-theme-doctocat/nav.yml @@ -87,6 +87,8 @@ url: /Overlay - title: Pagehead url: /Pagehead + - title: PageLayout + url: /PageLayout - title: Pagination url: /Pagination - title: PointerBox From ce0acc78730248c9429992ca2067cbe5b0d74a3f Mon Sep 17 00:00:00 2001 From: Cole Bemis Date: Wed, 23 Feb 2022 08:04:51 -0800 Subject: [PATCH 4/5] Update .changeset/odd-apes-guess.md Co-authored-by: Rez --- .changeset/odd-apes-guess.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.changeset/odd-apes-guess.md b/.changeset/odd-apes-guess.md index 64e10ea3b85..e15f28b4809 100644 --- a/.changeset/odd-apes-guess.md +++ b/.changeset/odd-apes-guess.md @@ -2,7 +2,9 @@ "@primer/react": major --- -`PageLayout` has been moved from the `drafts` bundle to the main bundle. To upgrade, rewrite your imports accordingly: +`PageLayout` is being graduated from the `drafts` bundle to the `main` bundle. + +To upgrade, rewrite your imports accordingly: ```diff - import {PageLayout} from '@primer/react/drafts' From a46572bcd4ccae2c493736acb93869f0df319f56 Mon Sep 17 00:00:00 2001 From: Cole Bemis Date: Wed, 23 Feb 2022 08:15:51 -0800 Subject: [PATCH 5/5] Update PageLayout docs --- docs/content/{drafts => }/PageLayout.mdx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) rename docs/content/{drafts => }/PageLayout.mdx (97%) diff --git a/docs/content/drafts/PageLayout.mdx b/docs/content/PageLayout.mdx similarity index 97% rename from docs/content/drafts/PageLayout.mdx rename to docs/content/PageLayout.mdx index a04cfc87307..64d439c49d3 100644 --- a/docs/content/drafts/PageLayout.mdx +++ b/docs/content/PageLayout.mdx @@ -7,7 +7,7 @@ storybook: https://primer.style/react/storybook?path=/story/layout-pagelayout--p --- ```js -import {PageLayout} from '@primer/react/drafts' +import {PageLayout} from '@primer/react' ``` ## Examples @@ -20,7 +20,7 @@ See [storybook](https://primer.style/react/storybook?path=/story/layout-pagelayo ### Default -```jsx live drafts +```jsx live @@ -39,7 +39,7 @@ See [storybook](https://primer.style/react/storybook?path=/story/layout-pagelayo ### With dividers -```jsx live drafts +```jsx live @@ -58,7 +58,7 @@ See [storybook](https://primer.style/react/storybook?path=/story/layout-pagelayo ### With pane on left -```jsx live drafts +```jsx live @@ -77,7 +77,7 @@ See [storybook](https://primer.style/react/storybook?path=/story/layout-pagelayo ### With condensed spacing -```jsx live drafts +```jsx live @@ -96,7 +96,7 @@ See [storybook](https://primer.style/react/storybook?path=/story/layout-pagelayo ### Without header or footer -```jsx live drafts +```jsx live