Skip to content

Conversation

@siddharthkp
Copy link
Member

Dividers are decorative, so they should not role="separator" instead they should simply be aria-hidden

Merge checklist

  • Added/updated tests
  • NA Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@siddharthkp siddharthkp requested a review from rezrah December 22, 2021 14:13
@siddharthkp siddharthkp self-assigned this Dec 22, 2021
@siddharthkp siddharthkp requested a review from a team December 22, 2021 14:13
@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2021

🦋 Changeset detected

Latest commit: 99bfc74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 22, 2021

size-limit report 📦

Path Size
dist/browser.esm.js 58.91 KB (0%)
dist/browser.umd.js 59.24 KB (0%)

@siddharthkp siddharthkp merged commit 6e44d78 into main Jan 4, 2022
@siddharthkp siddharthkp deleted the siddharth/actionlist-aria-hidden-divider branch January 4, 2022 10:52
@primer-css primer-css mentioned this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants