From 75665d9eee7588fd24d3ae382a03431a9a02a7ad Mon Sep 17 00:00:00 2001
From: Siddharth Kshetrapal <siddharthkp@github.com>
Date: Mon, 20 Dec 2021 17:54:52 +0100
Subject: [PATCH 1/2] use h1 + h2 for Dialogs

---
 src/Dialog/ConfirmationDialog.tsx | 3 ++-
 src/Dialog/Dialog.tsx             | 9 +++++----
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/Dialog/ConfirmationDialog.tsx b/src/Dialog/ConfirmationDialog.tsx
index 3125a7ee329..03bd4b9214b 100644
--- a/src/Dialog/ConfirmationDialog.tsx
+++ b/src/Dialog/ConfirmationDialog.tsx
@@ -45,11 +45,12 @@ const StyledConfirmationHeader = styled.header`
   display: flex;
   flex-direction: row;
 `
-const StyledTitle = styled(Box)`
+const StyledTitle = styled(Box).attrs({as: 'h1'})`
   font-size: ${get('fontSizes.3')};
   font-weight: ${get('fontWeights.bold')};
   padding: 6px ${get('space.2')};
   flex-grow: 1;
+  margin: 0; /* override default margin */
 `
 const ConfirmationHeader: React.FC<DialogHeaderProps> = ({title, onClose, dialogLabelId}) => {
   const onCloseClick = useCallback(() => {
diff --git a/src/Dialog/Dialog.tsx b/src/Dialog/Dialog.tsx
index feec59e8d40..2cc91203db1 100644
--- a/src/Dialog/Dialog.tsx
+++ b/src/Dialog/Dialog.tsx
@@ -314,17 +314,18 @@ const Header = styled.div.attrs<SxProp>({as: 'header'})`
   flex-shrink: 0;
 `
 
-const Title = styled.div<SxProp>`
+const Title = styled.h1<SxProp>`
   font-size: ${get('fontSizes.1')};
   font-weight: ${get('fontWeights.bold')};
-
+  margin: 0; /* override default margin */
   ${sx};
 `
 
-const Subtitle = styled.div<SxProp>`
+const Subtitle = styled.h2<SxProp>`
   font-size: ${get('fontSizes.0')};
-  margin-top: ${get('space.1')};
   color: ${get('colors.fg.muted')};
+  margin: 0; /* override default margin */
+  margin-top: ${get('space.1')};
 
   ${sx};
 `

From 680361fea8c665b7e806891edb54274dd997b362 Mon Sep 17 00:00:00 2001
From: Siddharth Kshetrapal <siddharthkp@github.com>
Date: Mon, 20 Dec 2021 17:57:01 +0100
Subject: [PATCH 2/2] add changeset

---
 .changeset/dialogs-title-tag.md | 5 +++++
 1 file changed, 5 insertions(+)
 create mode 100644 .changeset/dialogs-title-tag.md

diff --git a/.changeset/dialogs-title-tag.md b/.changeset/dialogs-title-tag.md
new file mode 100644
index 00000000000..097115a5f29
--- /dev/null
+++ b/.changeset/dialogs-title-tag.md
@@ -0,0 +1,5 @@
+---
+'@primer/react': patch
+---
+
+Fix title and subtitle tag for Dialog2 and ConfirmationDialog