diff --git a/.changeset/dialogs-title-tag.md b/.changeset/dialogs-title-tag.md new file mode 100644 index 00000000000..097115a5f29 --- /dev/null +++ b/.changeset/dialogs-title-tag.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Fix title and subtitle tag for Dialog2 and ConfirmationDialog diff --git a/src/Dialog/ConfirmationDialog.tsx b/src/Dialog/ConfirmationDialog.tsx index 3125a7ee329..03bd4b9214b 100644 --- a/src/Dialog/ConfirmationDialog.tsx +++ b/src/Dialog/ConfirmationDialog.tsx @@ -45,11 +45,12 @@ const StyledConfirmationHeader = styled.header` display: flex; flex-direction: row; ` -const StyledTitle = styled(Box)` +const StyledTitle = styled(Box).attrs({as: 'h1'})` font-size: ${get('fontSizes.3')}; font-weight: ${get('fontWeights.bold')}; padding: 6px ${get('space.2')}; flex-grow: 1; + margin: 0; /* override default margin */ ` const ConfirmationHeader: React.FC = ({title, onClose, dialogLabelId}) => { const onCloseClick = useCallback(() => { diff --git a/src/Dialog/Dialog.tsx b/src/Dialog/Dialog.tsx index feec59e8d40..2cc91203db1 100644 --- a/src/Dialog/Dialog.tsx +++ b/src/Dialog/Dialog.tsx @@ -314,17 +314,18 @@ const Header = styled.div.attrs({as: 'header'})` flex-shrink: 0; ` -const Title = styled.div` +const Title = styled.h1` font-size: ${get('fontSizes.1')}; font-weight: ${get('fontWeights.bold')}; - + margin: 0; /* override default margin */ ${sx}; ` -const Subtitle = styled.div` +const Subtitle = styled.h2` font-size: ${get('fontSizes.0')}; - margin-top: ${get('space.1')}; color: ${get('colors.fg.muted')}; + margin: 0; /* override default margin */ + margin-top: ${get('space.1')}; ${sx}; `