-
Notifications
You must be signed in to change notification settings - Fork 646
implement Scroll flash into SelectPanel #1276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/6mK5FhKzNUt7CH8b64SRDZb5cb4o |
smockle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple comments re: code cleanup. I like the overall direction of this—nice idea, making it a hook! ✨
Co-authored-by: Clay Miller <[email protected]>
smockle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM! ✨
|
This is awesome! 🎉 |
Closes https://github.com/github/primer/issues/183
useScrollFlashtakes in a ref and implements https://adxlv.computer/projects/flash-scrollers/The issue implies that this should be a global solution for overlay components, but I think we will want to implement it in the specific use cases of Overlay being used - this is because the scrollable container itself is implemented in the specific use cases of
Overlayrather than globally on overlay itself.Looking at the issue, it seems the primary place where this was needed was SelectPanel, but we can easily put it elsewhere just by using the hook!
Screenshots
Merge checklist