Skip to content

Conversation

@T-Hugs
Copy link
Contributor

@T-Hugs T-Hugs commented Mar 3, 2021

The change in #1094 has caused errors to show up for Storybook stories. This PR resolves those errors.

@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2021

⚠️ No Changeset found

Latest commit: 591193b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/Bz3sHYagzopQkGRqPafqkqsqBm35
✅ Preview: https://primer-components-git-storybook-themeprovider-primer.vercel.app

@T-Hugs T-Hugs requested a review from colebemis March 3, 2021 19:21
Copy link
Contributor

@colebemis colebemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thank you, @T-Hugs! ❤️

Just curious, is there a way to avoid having to repeat this logic in every .stories.tsx file?

@vercel vercel bot temporarily deployed to Preview March 4, 2021 15:24 Inactive
@T-Hugs
Copy link
Contributor Author

T-Hugs commented Mar 4, 2021

@colebemis Not sure. Low on my list of priorities right now 😂

@T-Hugs T-Hugs merged commit 268a298 into main Mar 4, 2021
@T-Hugs T-Hugs deleted the storybook-themeprovider branch March 4, 2021 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants