-
Notifications
You must be signed in to change notification settings - Fork 644
Description
Describe the bug
The background color (defined in theme reference as colors.input.bg) is being ignored by the TextInput.tsx component. Apparently, this can be fixed by including the property in the list of default styles like so:
After running the test, a snapshot refresh was required, which showed the new property being applied correctly.
Note: As this is a public repo, please be careful not to include details or screenshots from unreleased GitHub products or features. In most cases, a good bug report should be able to describe the new component without including business logic or feature details, but if you must discuss context relating to an unreleased feature, please open an issue in the private Design Systems repo and link to it here.
To Reproduce
Steps to reproduce the behavior:
- Include the
<TextInput />component somewhere - Check the background colour of the
spanwrapper - The bg colour is not set
Expected behavior
Since there's a property in theme reference that exposes the bg property for this component, it should be used.
Screenshots
I find it difficult to showcase this issue using screenshots :P
Desktop (please complete the following information):
- OS:
Windows 10 - Browser:
Google Chrome - Version:
25
Smartphone (please complete the following information):
Not applicable
Additional context
This is not really a very big issue, and it's a one liner fix. But apparently I don't have enough disk space to make a PR myself! I'm sorry x.x
Thanks!
