Skip to content

Commit d62f317

Browse files
authored
Merge branch 'main' into improve-markdown-editor
2 parents bc5a62a + d46ae9f commit d62f317

File tree

5 files changed

+25
-32
lines changed

5 files changed

+25
-32
lines changed

.changeset/nice-apples-collect.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@primer/react': patch
3+
---
4+
5+
Remove z-index assignment that used to be necessary for the dropdown children of FilteredSearch

docs/content/FilteredSearch.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@ The FilteredSearch component helps style a Dropdown and a TextInput side-by-side
1515
<ActionMenu>
1616
<ActionMenu.Button as="summary">Filter</ActionMenu.Button>
1717
<ActionMenu.Overlay>
18-
<ActionList direction="sw">
18+
<ActionList>
1919
<ActionList.Item>Item 1</ActionList.Item>
2020
<ActionList.Item>Item 2</ActionList.Item>
2121
<ActionList.Item>Item 3</ActionList.Item>
2222
</ActionList>
2323
</ActionMenu.Overlay>
2424
</ActionMenu>
25-
<TextInput icon={SearchIcon} />
25+
<TextInput leadingVisual={SearchIcon} />
2626
</FilteredSearch>
2727
```
2828

package-lock.json

Lines changed: 18 additions & 28 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/FilteredSearch.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ const FilteredSearch = styled.div<SxProp>`
1818
border-radius: 0;
1919
border-top-right-radius: ${get('radii.2')};
2020
border-bottom-right-radius: ${get('radii.2')};
21-
z-index: 1; // Allows the focus outline to show on top of the dropdown.
2221
}
2322
2423
${sx}

src/__tests__/__snapshots__/FilteredSearch.test.tsx.snap

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ exports[`FilteredSearch renders consistently 1`] = `
2424
border-radius: 0;
2525
border-top-right-radius: 6px;
2626
border-bottom-right-radius: 6px;
27-
z-index: 1;
2827
}
2928
3029
<div

0 commit comments

Comments
 (0)