Skip to content

Commit cda5fc7

Browse files
committed
Clean up further
1 parent 8dbe325 commit cda5fc7

File tree

6 files changed

+3
-22
lines changed

6 files changed

+3
-22
lines changed

.changeset/lucky-gifts-rule.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
'@primer/react': minor
33
---
44

5-
Added `PageLayout.PaneHeading` slot to `PageLayout` which utilizes `<Heading>` as its base.
5+
Adjusts position of children within `PageLayout.Pane` to live above adjustable resize form.

docs/content/SplitPageLayout.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,13 +237,13 @@ If you need a more flexible layout component, consider using the [PageLayout](/P
237237
</Box>
238238
```
239239

240-
### With pane heading
240+
### With heading
241241

242242
```jsx live drafts
243243
<Box sx={{height: 320, overflowY: 'auto', border: '1px solid', borderColor: 'border.default'}}>
244244
<SplitPageLayout>
245245
<SplitPageLayout.Pane>
246-
<SplitPageLayout.PaneHeading as="h2">Pane Heading</SplitPageLayout.PaneHeading>
246+
<Heading as="h2">Pane Heading</Heading>
247247
<Placeholder label="Pane" height={120} />
248248
</SplitPageLayout.Pane>
249249
<SplitPageLayout.Content>

src/PageLayout/PageLayout.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -517,8 +517,6 @@ export type PageLayoutPaneProps = {
517517
resizable?: boolean
518518
widthStorageKey?: string
519519
padding?: keyof typeof SPACING_MAP
520-
heading?: string
521-
headingLevel?: 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6'
522520
divider?: 'none' | 'line' | ResponsiveValue<'none' | 'line', 'none' | 'line' | 'filled'>
523521
/**
524522
* @deprecated Use the `divider` prop with a responsive value instead.

src/SplitPageLayout/SplitPageLayout.docs.json

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -154,21 +154,6 @@
154154
"type": "SystemStyleObject"
155155
}
156156
]
157-
},
158-
{
159-
"name": "SplitPageLayout.PaneHeading",
160-
"props": [
161-
{
162-
"name": "as",
163-
"type": "'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6'",
164-
"required": true,
165-
"defaultValue": ""
166-
},
167-
{
168-
"name": "sx",
169-
"type": "SystemStyleObject"
170-
}
171-
]
172157
}
173158
]
174159
}

src/SplitPageLayout/SplitPageLayout.stories.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,6 @@ const Template: Story = args => (
340340
</SplitPageLayout.Content>
341341
{args['Render pane?'] ? (
342342
<SplitPageLayout.Pane
343-
heading={args['Pane.heading']}
344343
resizable={args['Pane.resizable']}
345344
position={{
346345
narrow: args['Pane.position.narrow'],

src/SplitPageLayout/SplitPageLayout.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import {
66
PageLayoutFooterProps,
77
PageLayoutHeaderProps,
88
PageLayoutPaneProps,
9-
PageLayoutPaneHeadingProps,
109
} from '../PageLayout'
1110

1211
// ----------------------------------------------------------------------------

0 commit comments

Comments
 (0)