Skip to content

Commit c9fbef6

Browse files
authored
ActionList: Prevent scroll when an item is selected with Space (#4259)
* prevent default on Space * immediately reset defaultPrevented * improve comment * Create slow-owls-report.md
1 parent 1159a72 commit c9fbef6

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

.changeset/slow-owls-report.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/react": patch
3+
---
4+
5+
ActionList: Prevent scroll when an item is selected with `Space`

packages/react/src/ActionList/Item.tsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,12 @@ export const Item = React.forwardRef<HTMLLIElement, ActionListItemProps>(
229229
(event: React.KeyboardEvent<HTMLLIElement>) => {
230230
if (disabled || inactive) return
231231
if ([' ', 'Enter'].includes(event.key)) {
232+
if (event.key === ' ') {
233+
event.preventDefault() // prevent scrolling on Space
234+
// immediately reset defaultPrevented once it's job is done
235+
// so as to not disturb the functions that use that event after this
236+
event.defaultPrevented = false
237+
}
232238
onSelect(event, afterSelect)
233239
}
234240
},

0 commit comments

Comments
 (0)