Skip to content

Commit c7b4268

Browse files
committed
Merge branch 'treeview-roving-tabindex' of github.com:primer/react into treeview-roving-tabindex
2 parents b0e802b + 99375d2 commit c7b4268

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/react": patch
3+
---
4+
5+
Dialog: Remove landmark elements to improve accessibility

.changeset/wise-keys-drum.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/react": patch
3+
---
4+
5+
TreeView: Use roving tabindex instead of `aria-activedescendant` for improved VoiceOver support in Safari

src/Dialog/Dialog.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,7 @@ const _Dialog = React.forwardRef<HTMLDivElement, React.PropsWithChildren<DialogP
313313
})
314314
_Dialog.displayName = 'Dialog'
315315

316-
const Header = styled.div.attrs<SxProp>({as: 'header'})`
316+
const Header = styled.div<SxProp>`
317317
box-shadow: 0 1px 0 ${get('colors.border.default')};
318318
padding: ${get('space.2')};
319319
z-index: 1;
@@ -344,7 +344,7 @@ const Body = styled.div<SxProp>`
344344
${sx};
345345
`
346346

347-
const Footer = styled.div.attrs<SxProp>({as: 'footer'})`
347+
const Footer = styled.div<SxProp>`
348348
box-shadow: 0 -1px 0 ${get('colors.border.default')};
349349
padding: ${get('space.3')};
350350
display: flex;

0 commit comments

Comments
 (0)