Skip to content

Commit c5bd189

Browse files
committed
Add block fallback for display variable
1 parent a1bf5cc commit c5bd189

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
.Hidden {
22
@media screen and (--viewportRange-narrow) {
3-
display: var(--hiddenDisplay-narrow);
3+
display: var(--hiddenDisplay-narrow, block);
44
}
55

66
@media screen and (--viewportRange-regular) {
7-
display: var(--hiddenDisplay-regular);
7+
display: var(--hiddenDisplay-regular, block);
88
}
99

1010
@media screen and (--viewportRange-wide) {
11-
display: var(--hiddenDisplay-wide);
11+
display: var(--hiddenDisplay-wide, block);
1212
}
1313
}

packages/react/src/Hidden/Hidden.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import React from 'react'
1+
import React, {type CSSProperties} from 'react'
22
import {clsx} from 'clsx'
33
import type {ResponsiveValue} from '../hooks/useResponsiveValue'
44
import {getBreakpointDeclarations} from '../utils/getBreakpointDeclarations'
@@ -14,6 +14,7 @@ export type HiddenProps = {
1414
when: Array<Viewport> | Viewport
1515
children: React.ReactNode
1616
className?: string
17+
style?: CSSProperties
1718
}
1819

1920
/* Normalize the value that is received from the prop `when`.
@@ -37,7 +38,7 @@ function normalize(hiddenViewports: Array<Viewport> | Viewport): ResponsiveValue
3738
}
3839
}
3940

40-
export const Hidden = ({when, className, children}: HiddenProps) => {
41+
export const Hidden = ({when, className, style, children}: HiddenProps) => {
4142
const enabled = useFeatureFlag(CSS_MODULES_FEATURE_FLAG)
4243
const normalizedStyles = normalize(when)
4344

@@ -52,7 +53,8 @@ export const Hidden = ({when, className, children}: HiddenProps) => {
5253
'--hiddenDisplay-narrow': normalizedStyles.narrow ? 'none' : undefined,
5354
'--hiddenDisplay-regular': normalizedStyles.regular ? 'none' : undefined,
5455
'--hiddenDisplay-wide': normalizedStyles.wide ? 'none' : undefined,
55-
} as React.CSSProperties
56+
...style,
57+
} as CSSProperties
5658
}
5759
>
5860
{children}

0 commit comments

Comments
 (0)