Skip to content

Commit b80ea33

Browse files
siddharthkplukasoppermann
authored andcommitted
Dialog v1: Fix title font family (#4246)
* don't need to set fontFamily, inherit it * Create hot-hounds-speak.md * test(vrt): update snapshots --------- Co-authored-by: siddharthkp <[email protected]>
1 parent f0fc3de commit b80ea33

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

.changeset/hot-hounds-speak.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/react": patch
3+
---
4+
5+
Dialog v1: Fix font-family for title

packages/react/src/Dialog.stories.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export const Default = () => {
2828
<div data-testid="inner">
2929
<Dialog.Header id="header">Title</Dialog.Header>
3030
<Box p={3}>
31-
<Text fontFamily="sans-serif">Some content</Text>
31+
<Text>Some content</Text>
3232
</Box>
3333
</div>
3434
</Dialog>

packages/react/src/Dialog.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export type DialogHeaderProps = ComponentProps<typeof DialogHeaderBase>
5757
function DialogHeader({theme, children, backgroundColor = 'canvas.subtle', ...rest}: DialogHeaderProps) {
5858
if (React.Children.toArray(children).every(ch => typeof ch === 'string')) {
5959
children = (
60-
<Text theme={theme} color="fg.default" fontSize={1} fontWeight="bold" fontFamily="sans-serif">
60+
<Text fontSize={1} fontWeight="bold">
6161
{children}
6262
</Text>
6363
)

0 commit comments

Comments
 (0)