fix: ActionList.LinkItem duplicate classes (#5517)

francinelucca · francinelucca · commit 8c1cff46f206 · 2025-01-09T12:39:24.000-05:00
* remove className from menuItemProps

* Create little-shrimps-hug.md
diff --git a/.changeset/little-shrimps-hug.md b/.changeset/little-shrimps-hug.md
@@ -0,0 +1,5 @@
+---
+"@primer/react": patch
+---
+
+fix(ActionList): remove className from menuItemProps to prevent duplicate className bug
diff --git a/packages/react/src/ActionList/Item.tsx b/packages/react/src/ActionList/Item.tsx
@@ -335,7 +335,6 @@ export const Item = React.forwardRef<HTMLLIElement, ActionListItemProps>(
       ...(includeSelectionAttribute && {[itemSelectionAttribute]: selected}),
       role: itemRole,
       id: itemId,
-      className,
     }
 
     const containerProps = _PrivateItemWrapper

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@primer/react": patch
 +---
++
 +fix(ActionList): remove className from menuItemProps to prevent duplicate className bug
Original file line number	Diff line number	Diff line change
`@@ -335,7 +335,6 @@ export const Item = React.forwardRef<HTMLLIElement, ActionListItemProps>(`
`335`	`335`	`...(includeSelectionAttribute && {[itemSelectionAttribute]: selected}),`
`336`	`336`	`role: itemRole,`
`337`	`337`	`id: itemId,`
`338`		`- className,`
`339`	`338`	`}`
`340`	`339`
`341`	`340`	`const containerProps = _PrivateItemWrapper`