Skip to content

Commit 86cd9f0

Browse files
fix: user red focus state for inputs when in error state (#5742)
1 parent a4137bc commit 86cd9f0

File tree

6 files changed

+137
-133
lines changed

6 files changed

+137
-133
lines changed

.changeset/seven-chairs-act.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@primer/react": patch
3+
---
4+
5+
fix: user red focus state for inputs when in error state

packages/react/src/__tests__/__snapshots__/Autocomplete.test.tsx.snap

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,8 @@ exports[`snapshots renders a custom empty state message 1`] = `
111111
112112
.c0:where([data-validation='error']):where([data-trailing-action][data-focused]),
113113
.c0:where([data-validation='error']):where(:not([data-trailing-action])):focus-within {
114-
border-color: var(--fgColor-accent,var(--color-accent-fg,#0969da));
115-
outline: 2px solid var(--fgColor-accent,var(--color-accent-fg,#0969da));
114+
border-color: var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
115+
outline: 2px solid var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
116116
outline-offset: -1px;
117117
}
118118
@@ -392,8 +392,8 @@ exports[`snapshots renders a loading state 1`] = `
392392
393393
.c0:where([data-validation='error']):where([data-trailing-action][data-focused]),
394394
.c0:where([data-validation='error']):where(:not([data-trailing-action])):focus-within {
395-
border-color: var(--fgColor-accent,var(--color-accent-fg,#0969da));
396-
outline: 2px solid var(--fgColor-accent,var(--color-accent-fg,#0969da));
395+
border-color: var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
396+
outline: 2px solid var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
397397
outline-offset: -1px;
398398
}
399399
@@ -725,8 +725,8 @@ exports[`snapshots renders a menu that contains an item to add to the menu 1`] =
725725
726726
.c0:where([data-validation='error']):where([data-trailing-action][data-focused]),
727727
.c0:where([data-validation='error']):where(:not([data-trailing-action])):focus-within {
728-
border-color: var(--fgColor-accent,var(--color-accent-fg,#0969da));
729-
outline: 2px solid var(--fgColor-accent,var(--color-accent-fg,#0969da));
728+
border-color: var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
729+
outline: 2px solid var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
730730
outline-offset: -1px;
731731
}
732732
@@ -1687,8 +1687,8 @@ exports[`snapshots renders a multiselect input 1`] = `
16871687
16881688
.c0:where([data-validation='error']):where([data-trailing-action][data-focused]),
16891689
.c0:where([data-validation='error']):where(:not([data-trailing-action])):focus-within {
1690-
border-color: var(--fgColor-accent,var(--color-accent-fg,#0969da));
1691-
outline: 2px solid var(--fgColor-accent,var(--color-accent-fg,#0969da));
1690+
border-color: var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
1691+
outline: 2px solid var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
16921692
outline-offset: -1px;
16931693
}
16941694
@@ -2529,8 +2529,8 @@ exports[`snapshots renders a multiselect input with selected menu items 1`] = `
25292529
25302530
.c0:where([data-validation='error']):where([data-trailing-action][data-focused]),
25312531
.c0:where([data-validation='error']):where(:not([data-trailing-action])):focus-within {
2532-
border-color: var(--fgColor-accent,var(--color-accent-fg,#0969da));
2533-
outline: 2px solid var(--fgColor-accent,var(--color-accent-fg,#0969da));
2532+
border-color: var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
2533+
outline: 2px solid var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
25342534
outline-offset: -1px;
25352535
}
25362536
@@ -3559,8 +3559,8 @@ exports[`snapshots renders a single select input 1`] = `
35593559
35603560
.c0:where([data-validation='error']):where([data-trailing-action][data-focused]),
35613561
.c0:where([data-validation='error']):where(:not([data-trailing-action])):focus-within {
3562-
border-color: var(--fgColor-accent,var(--color-accent-fg,#0969da));
3563-
outline: 2px solid var(--fgColor-accent,var(--color-accent-fg,#0969da));
3562+
border-color: var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
3563+
outline: 2px solid var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
35643564
outline-offset: -1px;
35653565
}
35663566
@@ -4783,8 +4783,8 @@ exports[`snapshots renders with an input value 1`] = `
47834783
47844784
.c0:where([data-validation='error']):where([data-trailing-action][data-focused]),
47854785
.c0:where([data-validation='error']):where(:not([data-trailing-action])):focus-within {
4786-
border-color: var(--fgColor-accent,var(--color-accent-fg,#0969da));
4787-
outline: 2px solid var(--fgColor-accent,var(--color-accent-fg,#0969da));
4786+
border-color: var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
4787+
outline: 2px solid var(--borderColor-danger-emphasis,var(--color-danger-emphasis,#cf222e));
47884788
outline-offset: -1px;
47894789
}
47904790

0 commit comments

Comments
 (0)